You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2013/03/22 17:33:24 UTC
svn commit: r1459891 -
/hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
Author: hashutosh
Date: Fri Mar 22 16:33:24 2013
New Revision: 1459891
URL: http://svn.apache.org/r1459891
Log:
HIVE-4180
Summary: Filter getting pushed above PTF Operator when it should not.
Test Plan: Added new test which demonstrates the problem.
Reviewers: hbutani
Differential Revision: https://reviews.facebook.net/D9435
Modified:
hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
Modified: hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
URL: http://svn.apache.org/viewvc/hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java?rev=1459891&r1=1459890&r2=1459891&view=diff
==============================================================================
--- hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java (original)
+++ hive/branches/ptf-windowing/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java Fri Mar 22 16:33:24 2013
@@ -525,17 +525,6 @@ public final class OpProcFactory {
}
- public static class PTFPPD extends DefaultPPD {
-
- @Override
- public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
- Object... nodeOutputs) throws SemanticException {
- LOG.info("Processing for " + nd.getName() + "("+ ((Operator<?>) nd).getIdentifier() + ")");
- // It's not safe to push filters up through PTFPPD.
- ((OpWalkerInfo) procCtx).getCandidateFilterOps().clear();
- return null;
- }
- }
/**
* Default processor which just merges its children.
*/
@@ -858,7 +847,7 @@ public final class OpProcFactory {
}
public static NodeProcessor getPTFProc() {
- return new PTFPPD();
+ return new ScriptPPD();
}
public static NodeProcessor getSCRProc() {