You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by George Sirois <ge...@gmail.com> on 2015/02/05 22:43:34 UTC
Review Request 30695: Implements log rotation in the Thermos runner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30695/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-95
https://issues.apache.org/jira/browse/AURORA-95
Repository: aurora
Description
-------
Implements log rotation in the Thermos runner.
Diffs
-----
docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py dd638801c377065711378b3639b98b8116d8e526
src/main/python/apache/aurora/executor/thermos_task_runner.py dd5cf12856e0412f4e2e03ad7fb5f031776c38c4
src/main/python/apache/thermos/bin/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211
src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99
src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa
src/test/python/apache/thermos/core/test_process.py e261249b977802851ffc3d89437761c532fcd3f8
Diff: https://reviews.apache.org/r/30695/diff/
Testing
-------
./pants test src/test/python/apache/thermos/core:all
Thanks,
George Sirois
Re: Review Request 30695: Implements log rotation in the Thermos
runner.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30695/#review71329
-----------------------------------------------------------
Master (1c78721) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_process ..... FAILURE
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 5, 2015, 9:43 p.m., George Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30695/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 9:43 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-95
> https://issues.apache.org/jira/browse/AURORA-95
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implements log rotation in the Thermos runner.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py dd638801c377065711378b3639b98b8116d8e526
> src/main/python/apache/aurora/executor/thermos_task_runner.py dd5cf12856e0412f4e2e03ad7fb5f031776c38c4
> src/main/python/apache/thermos/bin/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211
> src/main/python/apache/thermos/core/process.py 5ce138dab161d880c0bd58b87a6f5a54d4ca2f99
> src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa
> src/test/python/apache/thermos/core/test_process.py e261249b977802851ffc3d89437761c532fcd3f8
>
> Diff: https://reviews.apache.org/r/30695/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core:all
>
>
> Thanks,
>
> George Sirois
>
>