[jira] [Commented] (FLINK-8836) Duplicating a KryoSerializer does not duplicate registered default serializers

["Stefan Richter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442589#comment-16442589 ] 

Stefan Richter commented on FLINK-8836:
---------------------------------------

Hi, I have seen a report on the mailing list that could bring a decision to this issue. The user was registering a {{ProtobufSerializer}} as default serializer and it failed. His fix was to use a different class in the state that would not go through the default serializer. I think that makes a case for duplicating the serializer for safety reasons, what do you think?

> Duplicating a KryoSerializer does not duplicate registered default serializers
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-8836
>                 URL: https://issues.apache.org/jira/browse/FLINK-8836
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>            Priority: Major
>
> The {{duplicate()}} method of the {{KryoSerializer}} is as following:
> {code:java}
> public KryoSerializer<T> duplicate() {
>     return new KryoSerializer<>(this);
> }
> protected KryoSerializer(KryoSerializer<T> toCopy) {
>     defaultSerializers = toCopy.defaultSerializers;
>     defaultSerializerClasses = toCopy.defaultSerializerClasses;
>     kryoRegistrations = toCopy.kryoRegistrations;
>     ...
> }
> {code}
> Shortly put, when duplicating a {{KryoSerializer}}, the {{defaultSerializers}} serializer instances are directly provided to the new {{KryoSerializer}} instance.
>  This causes the fact that those default serializers are shared across two different {{KryoSerializer}} instances, and therefore not a correct duplicate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)