[jira] [Commented] (BEAM-4114) Allow null as leftNullValue/rightNullValue in Join.fullOuterJoin()

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179775#comment-17179775 ] 

Beam JIRA Bot commented on BEAM-4114:
-------------------------------------

This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3.

Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean.


> Allow null as leftNullValue/rightNullValue in Join.fullOuterJoin()
> ------------------------------------------------------------------
>
>                 Key: BEAM-4114
>                 URL: https://issues.apache.org/jira/browse/BEAM-4114
>             Project: Beam
>          Issue Type: Improvement
>          Components: extensions-java-join-library
>    Affects Versions: 2.4.0
>            Reporter: Robin Trietsch
>            Priority: P2
>              Labels: stale-P2
>
> When using the [Join.fullOuterJoin()|https://beam.apache.org/documentation/sdks/javadoc/2.4.0/org/apache/beam/sdk/extensions/joinlibrary/Join.html#fullOuterJoin-org.apache.beam.sdk.values.PCollection-org.apache.beam.sdk.values.PCollection-V1-V2-], a checkNotNull() is done for the [leftNullValue|https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java#L207] and [rightNullValue|https://github.com/apache/beam/blob/master/sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java#L208].
> However, it makes more sense to allow null values, since sometimes, if the key used for the join is not the same, you'd like to see that the value will become null. This should be decided by the developer, and not by the join library.
> Looking at the source code, this is also supported by [KV.of()|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/KV.java#L42] (it allows null values), which is used in Join.fullOuterJoin().
> If required, I can create a pull request on GitHub.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)