You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/12/20 17:11:01 UTC
[GitHub] [streampipes] smlabt opened a new pull request, #875: [WIP][#771] add pre commit hook for linting and formatting
smlabt opened a new pull request, #875:
URL: https://github.com/apache/streampipes/pull/875
Closes #771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe merged pull request #875: [#771] add pre commit hook for linting and formatting
Posted by GitBox <gi...@apache.org>.
tenthe merged PR #875:
URL: https://github.com/apache/streampipes/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #875: [#771] add pre commit hook for linting and formatting
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #875:
URL: https://github.com/apache/streampipes/pull/875#discussion_r1054019436
##########
ui/.husky/pre-commit:
##########
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
Review Comment:
great to here, +1 for having a dedicated PR for the reformatting
With regard to our Java codebase we apply the code style check module by module in #820.
Do you think splitting up would also make sense for the UI somehow although we don't have the same module structure there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe commented on a diff in pull request #875: [#771] add pre commit hook for linting and formatting
Posted by GitBox <gi...@apache.org>.
tenthe commented on code in PR #875:
URL: https://github.com/apache/streampipes/pull/875#discussion_r1054068687
##########
ui/.husky/pre-commit:
##########
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
Review Comment:
Hi, thanks a lot for the PR @smlabt.
I'm in favor of activating it module by module (if that is possible), since I'm not sure if a "full" automated reformatting might have some unexpected side effects.
I guess it makes sense to first get a bit more comfortable with the styling guidelines. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on a diff in pull request #875: [#771] add pre commit hook for linting and formatting
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #875:
URL: https://github.com/apache/streampipes/pull/875#discussion_r1053762455
##########
ui/.husky/pre-commit:
##########
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
Review Comment:
Please add an apache header here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] smlabt commented on a diff in pull request #875: [#771] add pre commit hook for linting and formatting
Posted by GitBox <gi...@apache.org>.
smlabt commented on code in PR #875:
URL: https://github.com/apache/streampipes/pull/875#discussion_r1053779734
##########
ui/.husky/pre-commit:
##########
@@ -0,0 +1,4 @@
+#!/usr/bin/env sh
Review Comment:
Hi @bossenti,
thanks for your feedback :) I will add the missing apache header and also some documentation for the initial setup.
I'm also already working on a CI integration, but I think we should open a second PR for this. This second PR will be very large, because we have to "prettify" all existing files, in order to pass the CI pipeline. And I think this is not closely related to the pre commit hook. What's your opionion on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org