You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by kishore g <g....@gmail.com> on 2020/03/03 22:52:08 UTC
Re: Pinot-incubator question about unofficial publications
This looks good to me. Adding dev to see if others have any concerns.
On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com> wrote:
> Hello ASF Pinot mentors!
>
>
>
> We are looking for a way for Apache Pinot (incubator) to host nightly,
> unofficial binary publications. Can you review our high-level approach and
> let us know if it aligns with ASF release policy? The information we found
> in ASF release policy seems to be compliant with our idea, but we wanted to
> double check with you.
>
>
>
> - Every night a CI job builds Pinot and publishes binaries to
> "pinot-nightly" Bintray repository
>
> - Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
>
> - The publications are not announced and not present in well-known public
> repositories
>
>
>
> ASF policy about test/nightly publications (
> http://www.apache.org/legal/release-policy.html#host-rc):
>
>
>
> "Test packages are for use by consenting developers and interested
> community members only, so they should not be hosted or linked on pages
> intended for end users. They should not be mirrored; only blessed GA
> releases should be mirrored."
>
>
>
> We'd appreciate guidance and review of our approach. We’re happy to
> describe more details if needed!
>
> Thank you!
>
> --
>
> Szczepan Faber - tech lead Dev Tools (
> https://www.linkedin.com/in/szczepanf/)
>
> How to give great code reviews
> <https://thenewstack.io/linkedin-code-review/>?
>
Re: Pinot-incubator question about unofficial publications
Posted by Subbu Subramaniam <mc...@apache.org>.
As far as I could gather, the main point was to ensure that these are NOT called apache pinot releases , which they will not be.
Any others have any concerns about this?
thanks
-Subbu
On 2020/03/03 22:52:08, kishore g <g....@gmail.com> wrote:
> This looks good to me. Adding dev to see if others have any concerns.
>
> On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com> wrote:
>
> > Hello ASF Pinot mentors!
> >
> >
> >
> > We are looking for a way for Apache Pinot (incubator) to host nightly,
> > unofficial binary publications. Can you review our high-level approach and
> > let us know if it aligns with ASF release policy? The information we found
> > in ASF release policy seems to be compliant with our idea, but we wanted to
> > double check with you.
> >
> >
> >
> > - Every night a CI job builds Pinot and publishes binaries to
> > "pinot-nightly" Bintray repository
> >
> > - Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
> >
> > - The publications are not announced and not present in well-known public
> > repositories
> >
> >
> >
> > ASF policy about test/nightly publications (
> > http://www.apache.org/legal/release-policy.html#host-rc):
> >
> >
> >
> > "Test packages are for use by consenting developers and interested
> > community members only, so they should not be hosted or linked on pages
> > intended for end users. They should not be mirrored; only blessed GA
> > releases should be mirrored."
> >
> >
> >
> > We'd appreciate guidance and review of our approach. We’re happy to
> > describe more details if needed!
> >
> > Thank you!
> >
> > --
> >
> > Szczepan Faber - tech lead Dev Tools (
> > https://www.linkedin.com/in/szczepanf/)
> >
> > How to give great code reviews
> > <https://thenewstack.io/linkedin-code-review/>?
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org
Re: Pinot-incubator question about unofficial publications
Posted by Mayank Shrivastava <ma...@apache.org>.
SGTM
On Mon, Mar 9, 2020 at 10:48 AM kishore g <g....@gmail.com> wrote:
> I am also ok with this.
>
> On Mon, Mar 9, 2020 at 10:46 AM Subbu Subramaniam <mc...@apache.org>
> wrote:
>
> > No concerns.
> >
> > -Subbu
> >
> > On 2020/03/03 22:52:08, kishore g <g....@gmail.com> wrote:
> > > This looks good to me. Adding dev to see if others have any concerns.
> > >
> > > On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com>
> > wrote:
> > >
> > > > Hello ASF Pinot mentors!
> > > >
> > > >
> > > >
> > > > We are looking for a way for Apache Pinot (incubator) to host
> nightly,
> > > > unofficial binary publications. Can you review our high-level
> approach
> > and
> > > > let us know if it aligns with ASF release policy? The information we
> > found
> > > > in ASF release policy seems to be compliant with our idea, but we
> > wanted to
> > > > double check with you.
> > > >
> > > >
> > > >
> > > > - Every night a CI job builds Pinot and publishes binaries to
> > > > "pinot-nightly" Bintray repository
> > > >
> > > > - Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
> > > >
> > > > - The publications are not announced and not present in well-known
> > public
> > > > repositories
> > > >
> > > >
> > > >
> > > > ASF policy about test/nightly publications (
> > > > http://www.apache.org/legal/release-policy.html#host-rc):
> > > >
> > > >
> > > >
> > > > "Test packages are for use by consenting developers and interested
> > > > community members only, so they should not be hosted or linked on
> pages
> > > > intended for end users. They should not be mirrored; only blessed GA
> > > > releases should be mirrored."
> > > >
> > > >
> > > >
> > > > We'd appreciate guidance and review of our approach. We’re happy to
> > > > describe more details if needed!
> > > >
> > > > Thank you!
> > > >
> > > > --
> > > >
> > > > Szczepan Faber - tech lead Dev Tools (
> > > > https://www.linkedin.com/in/szczepanf/)
> > > >
> > > > How to give great code reviews
> > > > <https://thenewstack.io/linkedin-code-review/>?
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
> > For additional commands, e-mail: dev-help@pinot.apache.org
> >
> >
>
Re: Pinot-incubator question about unofficial publications
Posted by kishore g <g....@gmail.com>.
I am also ok with this.
On Mon, Mar 9, 2020 at 10:46 AM Subbu Subramaniam <mc...@apache.org>
wrote:
> No concerns.
>
> -Subbu
>
> On 2020/03/03 22:52:08, kishore g <g....@gmail.com> wrote:
> > This looks good to me. Adding dev to see if others have any concerns.
> >
> > On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com>
> wrote:
> >
> > > Hello ASF Pinot mentors!
> > >
> > >
> > >
> > > We are looking for a way for Apache Pinot (incubator) to host nightly,
> > > unofficial binary publications. Can you review our high-level approach
> and
> > > let us know if it aligns with ASF release policy? The information we
> found
> > > in ASF release policy seems to be compliant with our idea, but we
> wanted to
> > > double check with you.
> > >
> > >
> > >
> > > - Every night a CI job builds Pinot and publishes binaries to
> > > "pinot-nightly" Bintray repository
> > >
> > > - Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
> > >
> > > - The publications are not announced and not present in well-known
> public
> > > repositories
> > >
> > >
> > >
> > > ASF policy about test/nightly publications (
> > > http://www.apache.org/legal/release-policy.html#host-rc):
> > >
> > >
> > >
> > > "Test packages are for use by consenting developers and interested
> > > community members only, so they should not be hosted or linked on pages
> > > intended for end users. They should not be mirrored; only blessed GA
> > > releases should be mirrored."
> > >
> > >
> > >
> > > We'd appreciate guidance and review of our approach. We’re happy to
> > > describe more details if needed!
> > >
> > > Thank you!
> > >
> > > --
> > >
> > > Szczepan Faber - tech lead Dev Tools (
> > > https://www.linkedin.com/in/szczepanf/)
> > >
> > > How to give great code reviews
> > > <https://thenewstack.io/linkedin-code-review/>?
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
> For additional commands, e-mail: dev-help@pinot.apache.org
>
>
Re: Pinot-incubator question about unofficial publications
Posted by Subbu Subramaniam <mc...@apache.org>.
No concerns.
-Subbu
On 2020/03/03 22:52:08, kishore g <g....@gmail.com> wrote:
> This looks good to me. Adding dev to see if others have any concerns.
>
> On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com> wrote:
>
> > Hello ASF Pinot mentors!
> >
> >
> >
> > We are looking for a way for Apache Pinot (incubator) to host nightly,
> > unofficial binary publications. Can you review our high-level approach and
> > let us know if it aligns with ASF release policy? The information we found
> > in ASF release policy seems to be compliant with our idea, but we wanted to
> > double check with you.
> >
> >
> >
> > - Every night a CI job builds Pinot and publishes binaries to
> > "pinot-nightly" Bintray repository
> >
> > - Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
> >
> > - The publications are not announced and not present in well-known public
> > repositories
> >
> >
> >
> > ASF policy about test/nightly publications (
> > http://www.apache.org/legal/release-policy.html#host-rc):
> >
> >
> >
> > "Test packages are for use by consenting developers and interested
> > community members only, so they should not be hosted or linked on pages
> > intended for end users. They should not be mirrored; only blessed GA
> > releases should be mirrored."
> >
> >
> >
> > We'd appreciate guidance and review of our approach. We’re happy to
> > describe more details if needed!
> >
> > Thank you!
> >
> > --
> >
> > Szczepan Faber - tech lead Dev Tools (
> > https://www.linkedin.com/in/szczepanf/)
> >
> > How to give great code reviews
> > <https://thenewstack.io/linkedin-code-review/>?
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org
Re: Pinot-incubator question about unofficial publications
Posted by Szczepan Faber <sf...@linkedin.com.INVALID>.
Trying to close the loop on this, feedback we have got so far:
Kishore: LGTM
Justin: feedback -> a) why we need this? cannot consumers build from source? b) must not use the name “Apache Pinot Release” for the test releases.
a) It is more convenient for consumers to get the test artifacts than to compile from source (the project is relatively big). Also, it is a bit safer, easier to troubleshoot - the artifacts for a given test version are exactly the same for everyone. In addition, we are using the same build/CI as is used for official releases - this makes the artifacts closest to what they will be in the official release.
b) We will use “test builds” name and we will not announce them.
Any other thoughts/feedback? Can we close this thread and assume we can go ahead with this approach?
Thank you!
--
Szczepan Faber - tech lead Dev Tools (https://www.linkedin.com/in/szczepanf/)
How to give great code reviews<https://thenewstack.io/linkedin-code-review/>?
From: Szczepan Faber <sf...@linkedin.com>
Date: Thursday, March 5, 2020 at 2:29 PM
To: "g.kishore" <g....@gmail.com>, "dev@pinot.apache.org" <de...@pinot.apache.org>
Cc: "felixcheung@apache.org" <fe...@apache.org>, "jmclean@apache.org" <jm...@apache.org>, Subbu Subramaniam <ss...@linkedin.com>, Varidhi Garg <vg...@linkedin.com>
Subject: Re: Pinot-incubator question about unofficial publications
Copying the discussion we have with Justin so that other devs can chime in:
> I’m not sure that explains why they are needed. Why can’t people compile from source?
It is more convenient for consumers to get the test artifacts than to compile from source (the project is relatively big). Also, it is a bit safer, easier to troubleshoot - the artifacts for a given test version are exactly the same for everyone. In addition, we are using the same build/CI as is used for official releases - this makes the artifacts closest to what they will be in the official release.
Justin, is your recommendation to compile from source for our use case?
Thank you!
--
Szczepan Faber - tech lead Dev Tools (https://www.linkedin.com/in/szczepanf/)
How to give great code reviews<https://thenewstack.io/linkedin-code-review/>?
From: kishore g <g....@gmail.com>
Date: Tuesday, March 3, 2020 at 2:52 PM
To: Szczepan Faber <sf...@linkedin.com>, "dev@pinot.apache.org" <de...@pinot.apache.org>
Cc: "felixcheung@apache.org" <fe...@apache.org>, "jmclean@apache.org" <jm...@apache.org>, Subbu Subramaniam <ss...@linkedin.com>, Varidhi Garg <vg...@linkedin.com>
Subject: Re: Pinot-incubator question about unofficial publications
This looks good to me. Adding dev to see if others have any concerns.
On Tue, Mar 3, 2020 at 1:49 PM Szczepan Faber <sf...@linkedin.com>> wrote:
Hello ASF Pinot mentors!
We are looking for a way for Apache Pinot (incubator) to host nightly, unofficial binary publications. Can you review our high-level approach and let us know if it aligns with ASF release policy? The information we found in ASF release policy seems to be compliant with our idea, but we wanted to double check with you.
- Every night a CI job builds Pinot and publishes binaries to "pinot-nightly" Bintray repository
- Example versioning scheme: "0.3.0-dev.1", "0.3.0-dev.2"
- The publications are not announced and not present in well-known public repositories
ASF policy about test/nightly publications (http://www.apache.org/legal/release-policy.html#host-rc<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flegal%2Frelease-policy.html%23host-rc&data=02%7C01%7Csfaber%40linkedin.com%7C9458eb6804b04f5287e508d7bfc58bc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637188727488974121&sdata=NcUmFJjfk3memHQBXY6Y4JV28xXdURD7U7KxIZQCpdg%3D&reserved=0>):
"Test packages are for use by consenting developers and interested community members only, so they should not be hosted or linked on pages intended for end users. They should not be mirrored; only blessed GA releases should be mirrored."
We'd appreciate guidance and review of our approach. We’re happy to describe more details if needed!
Thank you!
--
Szczepan Faber - tech lead Dev Tools (https://www.linkedin.com/in/szczepanf/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.linkedin.com%2Fin%2Fszczepanf%2F&data=02%7C01%7Csfaber%40linkedin.com%7C9458eb6804b04f5287e508d7bfc58bc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637188727488974121&sdata=cNK9UtPctO0722XQEB878hcDsXQ1zCvqzDzGOI765KQ%3D&reserved=0>)
How to give great code reviews<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fthenewstack.io%2Flinkedin-code-review%2F&data=02%7C01%7Csfaber%40linkedin.com%7C9458eb6804b04f5287e508d7bfc58bc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637188727488984117&sdata=5FkHeRihIEcPmSSkqXHrhn%2FlNnAQh7qOkdEZcyUiuA8%3D&reserved=0>?