You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/05 07:31:15 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #8806: KAFKA-10108 The cached configs of SslFactory should be updated only i…

chia7712 commented on a change in pull request #8806:
URL: https://github.com/apache/kafka/pull/8806#discussion_r435739393



##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##########
@@ -134,11 +147,17 @@ private SslEngineFactory instantiateSslEngineFactory(Map<String, Object> configs
             sslEngineFactory = Utils.newInstance(sslEngineFactoryClass);
         }
         sslEngineFactory.configure(configs);
-        this.sslEngineFactoryConfig = configs;

Review comment:
       the caller will check new ssle engine factory later so we should not update the sslEngineFactoryConfig here 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org