You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 03:11:59 UTC

[GitHub] [flink] buptljy opened a new pull request #11104: [FLINK-16051] make Overview-Subtasks ID starts from 1

buptljy opened a new pull request #11104: [FLINK-16051] make Overview-Subtasks ID starts from 1
URL: https://github.com/apache/flink/pull/11104
 
 
   ## What is the purpose of the change
   
   The subtask id in Subtask UI starts from 0 which is not consistent with other ID in backpressure / checkpoint / watermark.
   
   ## Brief change log
   
   subtasks ID + 1
   
   ## Verifying this change
   
   ## Does this pull request potentially affect one of the following parts
   
   ## Documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586890133
 
 
   > Why did you opt for incrementing this subtask id? Now both the checkpoint and subtask id are inconsistent with the entire Flink runtime, including logging and metrics.
   
   @zentol I've struggled for a little bit here because:
   1. ID in subtasks starts from 0, while ID in checkpoint / watermark / backpressure starts from 1.
   2. Logging with #ExecutionVertex#subtaskIndex starts from 0, while Logging with #ExecutionVertex#taskNameWithSubtask starts from 1.
   
   The reason I choose incrementing ID in subtasks is that it may look more reasonable and intuitive from user's perspective(maybe not from developer's perspective). I didn't think of the metrics before but it should be included.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-587245879
 
 
   > I remember a similar discussion in the past (can't find it right now), with the conclusion being that the only proper solution would be to be consistent across the entire project.
   > However, at the time we did not see a good way to implement this, and I still don't see it now.
   > 
   > As a result we sticked with the existing inconsistency. Without a clear goal of what the final solution should be there is no point in taking intermediate steps, as in the worst case they go in the wrong direction.
   > 
   > Sure, starting the index with 1 is "nicer", but implies that in every log statement we have to remember to increment the subtask index.
   > At the same time, changing the subtask index for metrics/logs may create headaches for or even break existing setups.
   
   Makes sense to me. We can keep the JIRA issue for further discussion. Closing this now...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] buptljy edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
buptljy edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586890133
 
 
   > Why did you opt for incrementing this subtask id? Now both the checkpoint and subtask id are inconsistent with the entire Flink runtime, including logging and metrics.
   
   @zentol I've struggled for a little bit here because:
   1. ID in subtasks starts from 0, while ID in checkpoint / watermark / backpressure starts from 1.
   2. Logging with #ExecutionVertex#subtaskIndex starts from 0, while Logging with #ExecutionVertex#taskNameWithSubtask starts from 1.
   
   The reason I choose incrementing ID in subtasks is that it may look more reasonable and intuitive from user's perspective(maybe not from developer's perspective). I didn't think of the metrics before but it should be included.
   
   But if you think these IDs should start from 0, it's also acceptable for me because the most important thing is to unify the IDs so that uses won't get confused. Should I change it to start from  0?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] buptljy closed pull request #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
buptljy closed pull request #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586866130
 
 
   Why did you opt for incrementing this subtask id? Now both the checkpoint and subtask id are inconsistent with the entire Flink runtime, including logging and metrics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586914932
 
 
   <!--
   Meta data
   Hash:19d97a6442b75fe125a7ee0f6cda2da213143c2d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:19d97a6442b75fe125a7ee0f6cda2da213143c2d
   -->
   ## CI report:
   
   * 19d97a6442b75fe125a7ee0f6cda2da213143c2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11104: [FLINK-16051] make Overview-Subtasks ID starts from 1

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11104: [FLINK-16051] make Overview-Subtasks ID starts from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586800028
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 19d97a6442b75fe125a7ee0f6cda2da213143c2d (Mon Feb 17 03:14:54 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586914932
 
 
   <!--
   Meta data
   Hash:19d97a6442b75fe125a7ee0f6cda2da213143c2d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149250440 TriggerType:PUSH TriggerID:19d97a6442b75fe125a7ee0f6cda2da213143c2d
   Hash:19d97a6442b75fe125a7ee0f6cda2da213143c2d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5235 TriggerType:PUSH TriggerID:19d97a6442b75fe125a7ee0f6cda2da213143c2d
   -->
   ## CI report:
   
   * 19d97a6442b75fe125a7ee0f6cda2da213143c2d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149250440) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5235) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586945807
 
 
   I remember a similar discussion in the past (can't find it right now), with the conclusion being that the only proper solution would be to be consistent across the entire project.
   However, at the time we did not see a good way to implement this, and I still don't see it now.
   
   As a result we sticked with the existing inconsistency. Without a clear goal of what the final solution should be there is no point in taking intermediate steps, as in the worst case they go in the wrong direction.
   
   Sure, starting the index with 1 is "nicer", but implies that in every log statement we have to remember to increment the subtask index.
   At the same time, changing the subtask index for metrics/logs may create headaches for or even break existing setups.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586914932
 
 
   <!--
   Meta data
   Hash:19d97a6442b75fe125a7ee0f6cda2da213143c2d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149250440 TriggerType:PUSH TriggerID:19d97a6442b75fe125a7ee0f6cda2da213143c2d
   Hash:19d97a6442b75fe125a7ee0f6cda2da213143c2d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5235 TriggerType:PUSH TriggerID:19d97a6442b75fe125a7ee0f6cda2da213143c2d
   -->
   ## CI report:
   
   * 19d97a6442b75fe125a7ee0f6cda2da213143c2d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149250440) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5235) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services