You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mxnet.apache.org by "Junru Shao (JIRA)" <ji...@apache.org> on 2018/11/27 22:55:00 UTC

[jira] [Created] (MXNET-1233) Enable dynamic shape in CachedOp

Junru Shao created MXNET-1233:
---------------------------------

             Summary: Enable dynamic shape in CachedOp
                 Key: MXNET-1233
                 URL: https://issues.apache.org/jira/browse/MXNET-1233
             Project: Apache MXNet
          Issue Type: Improvement
            Reporter: Junru Shao


## Description ##
This PR enables dynamic shape in CachedOp, a.k.a. the backend supporting `HybridBlock` in Gluon.

In the forward pass, we have to invoke operators one-by-one because dynamic shape disallows us to allocate memory ahead of time.

The backward pass is actually unaffected, because after forward, shape of everything becomes known.

CC: @zheng-da @szha @yidawang

## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented: 
- For user-facing API changes, API doc string has been updated. 
- For new C++ functions in header files, their functionalities and arguments are documented. 
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

### Changes ###
- [x] Add `NaiveRunGraph` in imperative mode, in which operators are executed in a synchronized manner.
- [x] Add `NaiveForward` mode in CachedOp, which calls `NaiveRunGraph`.
- [x] Add `CheckDynamicShapeExists` in CachedOp, which tells whether the graph contains an operator returning dynamic shape.

## Comments ##
- Yet another mode in the executor of CachedOp. Perhaps we need to refactor some day.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org