You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/15 02:34:38 UTC
[GitHub] [camel-kamelets] djencks opened a new pull request #630: POC/WIP Main collect
djencks opened a new pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630
See https://github.com/apache/camel-website/issues/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999156663
There was a problem with finding the images... not sure how my local builds worked... should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999138725
LGTM at first sight btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000847868
yeah, I forgot to approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999301529
Ok, let's wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999131486
This is ready to review.... would be nice to get it in before there are a lot more new kamelets :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000076918
Netlify doesn’t understand httpd redirects, as hinted by the second line.
Try https://pr-735--camel.netlify.app/camel-kamelets/0.6.x/index.html
> On Dec 22, 2021, at 10:26 PM, Andrea Cosentino ***@***.***> wrote:
>
>
> Here
>
> https://pr-735--camel.netlify.app/camel-kamelets/latest/ <https://pr-735--camel.netlify.app/camel-kamelets/latest/>
> I'm getting
>
> This file exists solely to defeat the limitations of the link checker, that is unaware of the .htaccess redirect from this page to the latest released version.
>
> If you see this, you are not viewing the site through httpd or there is something wrong with the .htaccess file: in the latter case please let the camel developers know.
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000074642>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXVV5GIZYU24FIHZQXTUSK6H7ANCNFSM5KCPNZUQ>.
> You are receiving this because you authored the thread.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000074642
Here
https://pr-735--camel.netlify.app/camel-kamelets/latest/
I'm getting
This file exists solely to defeat the limitations of the link checker, that is unaware of the .htaccess redirect from this page to the latest released version.
If you see this, you are not viewing the site through httpd or there is something wrong with the .htaccess file: in the latter case please let the camel developers know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000553273
Is 'LGTM' the same as approval? I don't know what to do with the "changes requested" review since the code reviewed is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] nicolaferraro commented on pull request #630: POC/WIP Main collect
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-998638407
> Yes, at the moment both original and new versions of the kamelets pages are shown for easier comparison. One difference is that I changed how the "required" status of a property is shown to match the other tables I've worked on: instead of a star after the name, the description starts with at bold "Required".
Yes, the generator puts images into assets/images/kamelets, so I think this line needs to be changed: https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999133129
The generator script only generates the nav file now, but it's still loading the entire yaml into a model because I can't figure out how the name gets into the model or how to get it on it's own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000072459
This is all fixed (all 3 branches) and the preview is at https://pr-735--camel.netlify.app/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: POC/WIP Main collect
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999010591
I’ll try to finish this up…. the new stuff has Antora extract the image from the yml, IIRC the generator is not needed at all.
> On Dec 21, 2021, at 2:01 AM, Nicola Ferraro ***@***.***> wrote:
>
>
> Yes, at the moment both original and new versions of the kamelets pages are shown for easier comparison. One difference is that I changed how the "required" status of a property is shown to match the other tables I've worked on: instead of a star after the name, the description starts with at bold "Required".
>
> Yes, the generator puts images into assets/images/kamelets, so I think this line needs to be changed: https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360 <https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/camel-kamelets/pull/630#issuecomment-998638407>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXRSSQE62GRZOBIYXOLUSBF7RANCNFSM5KCPNZUQ>.
> You are receiving this because you authored the thread.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999247089
I think this PR will be OK but there's a bug in @djencks/asciidoctor-antora-indexer that prevents more than one set of components being generated properly in a full build. I'll let you know when it's fixed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #630: POC/WIP Main collect
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-995972907
Yes, at the moment both original and new versions of the kamelets pages are shown for easier comparison.
One difference is that I changed how the "required" status of a property is shown to match the other tables I've worked on: instead of a star after the name, the description starts with at bold "Required".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks merged pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
djencks merged pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #630: [Docs] Generate kamelets pages using Antora (main)
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-1000077325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org