You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "mkoncek (via GitHub)" <gi...@apache.org> on 2023/06/05 10:16:17 UTC
[GitHub] [commons-compress] mkoncek opened a new pull request, #389: Change source encoding to UTF-8
mkoncek opened a new pull request, #389:
URL: https://github.com/apache/commons-compress/pull/389
We have a project which bootstraps Maven. It manually calls `javac` and we encountered a problem with source encoding.
I would like to unify source encodings to UTF-8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] garydgregory commented on pull request #389: Change source encoding to UTF-8
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1576576537
Hello @mkoncek
How can this goal be enforced such that this build fails without the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change source encoding to UTF-8 [commons-compress]
Posted by "sschuberth (via GitHub)" <gi...@apache.org>.
sschuberth commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1886507122
> How can this goal be enforced such that this build fails without the change?
Maybe by adding a UTF-8 encoded test asset, plus a test that reads the file in binary mode and compares to the expected bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] sebbASF commented on a diff in pull request #389: Change source encoding to UTF-8
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #389:
URL: https://github.com/apache/commons-compress/pull/389#discussion_r1217913999
##########
src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java:
##########
@@ -297,7 +297,7 @@ private void addPaxHeadersForBigNumbers(final Map<String, String> paxHeaders,
TarConstants.MAXID);
// libarchive extensions
addFileTimePaxHeader(paxHeaders, "LIBARCHIVE.creationtime", entry.getCreationTime());
- // star extensions by J�rg Schilling
+ // star extensions by Jörg Schilling
Review Comment:
Could also use:
// star extensions by Joerg Schilling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1578364570
Unfortunately, when using fork=true, some informational messages are not shown, see:
https://issues.apache.org/jira/browse/MCOMPILER-537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] mkoncek commented on pull request #389: Change source encoding to UTF-8
Posted by "mkoncek (via GitHub)" <gi...@apache.org>.
mkoncek commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1576651634
maven-compiler-plugin is declared in `commons-parent` which also uses the `encoding` field. I rebased the PR so that the build reports an error the same way as `javac` would in our case. I don't know why the build doesn't fail, but there is an `[ERROR]` in the log if encoding is set and current sources are used.
`commons-parent` uses ISO-8859 encoding by default.
@sebbASF That would work too, but I believe it is time we can afford such luxury as using non-ASCII-only characters in sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1578190656
See https://issues.apache.org/jira/browse/MCOMPILER-491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] sebbASF commented on pull request #389: Change source encoding to UTF-8
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1576896714
I can confirm that changing the encoding causes the compile to report an ERROR, but the build succeeds:
$ mvn clean compile -Dcommons.encoding=UTF8
...
[INFO] Compiling 399 source files with javac [debug release 8] to target/classes
[ERROR] /commons/compress/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java:[300,32] unmappable character (0xF6) for encoding UTF-8
...
[INFO] BUILD SUCCESS
I've tried experimenting with -Dmaven.compiler.failOnWarning=true (and failOnError), but Maven does not fail the build.
However, adding -Dcommons.compiler.fork=true does cause the build to fail.
Possible bug in Maven?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change source encoding to UTF-8 [commons-compress]
Posted by "sschuberth (via GitHub)" <gi...@apache.org>.
sschuberth commented on code in PR #389:
URL: https://github.com/apache/commons-compress/pull/389#discussion_r1448423980
##########
src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java:
##########
@@ -297,7 +297,7 @@ private void addPaxHeadersForBigNumbers(final Map<String, String> paxHeaders,
TarConstants.MAXID);
// libarchive extensions
addFileTimePaxHeader(paxHeaders, "LIBARCHIVE.creationtime", entry.getCreationTime());
- // star extensions by J�rg Schilling
+ // star extensions by Jörg Schilling
Review Comment:
Actually, strictly (legally) speaking, "Jörg" and "Joerg" are not the same name, just like "Möller" and "Moeller" are not. So better stick to the original for credits / Copyrights, if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org