You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by al...@apache.org on 2019/03/11 13:13:44 UTC

[nifi-minifi-cpp] branch master updated: MINIFICPP-761: Carry repo name to instance

This is an automated email from the ASF dual-hosted git repository.

aldrin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 3795d4d  MINIFICPP-761: Carry repo name to instance
3795d4d is described below

commit 3795d4d5fa8cb26a40c38e522b75fd091ab08116
Author: Marc Parisi <ph...@apache.org>
AuthorDate: Mon Mar 11 07:25:08 2019 -0400

    MINIFICPP-761: Carry repo name to instance
---
 libminifi/src/core/RepositoryFactory.cpp   | 1 +
 libminifi/test/rocksdb-tests/RepoTests.cpp | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/libminifi/src/core/RepositoryFactory.cpp b/libminifi/src/core/RepositoryFactory.cpp
index d753a90..82ed53a 100644
--- a/libminifi/src/core/RepositoryFactory.cpp
+++ b/libminifi/src/core/RepositoryFactory.cpp
@@ -42,6 +42,7 @@ std::shared_ptr<core::Repository> createRepository(const std::string configurati
 
     auto ptr = core::ClassLoader::getDefaultClassLoader().instantiate<core::Repository>(class_name_lc, class_name_lc);
     if (nullptr != ptr) {
+      ptr->setName(repo_name);
       return_obj = ptr;
     }
 
diff --git a/libminifi/test/rocksdb-tests/RepoTests.cpp b/libminifi/test/rocksdb-tests/RepoTests.cpp
index bf9f51c..f8b26a3 100644
--- a/libminifi/test/rocksdb-tests/RepoTests.cpp
+++ b/libminifi/test/rocksdb-tests/RepoTests.cpp
@@ -27,8 +27,17 @@
 #include "core/Core.h"
 #include "FlowFileRepository.h"
 #include "core/repository/AtomicRepoEntries.h"
+#include "core/RepositoryFactory.h"
 #include "properties/Configure.h"
 
+TEST_CASE("Test Repo Names", "[TestFFR1]") {
+  auto repoA = minifi::core::createRepository("FlowFileRepository", false, "flowfile");
+  REQUIRE("flowfile" == repoA->getName());
+
+  auto repoB = minifi::core::createRepository("ProvenanceRepository", false, "provenance");
+  REQUIRE("provenance" == repoB->getName());
+}
+
 TEST_CASE("Test Repo Empty Value Attribute", "[TestFFR1]") {
   LogTestController::getInstance().setDebug<core::ContentRepository>();
   LogTestController::getInstance().setDebug<core::repository::FileSystemRepository>();