You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Koji Sekiguchi (JIRA)" <ji...@apache.org> on 2010/05/15 18:05:43 UTC
[jira] Created: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
FastVectorHighlighter: add a FragmentBuilder to return entire field contents
----------------------------------------------------------------------------
Key: LUCENE-2464
URL: https://issues.apache.org/jira/browse/LUCENE-2464
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/highlighter
Reporter: Koji Sekiguchi
Priority: Minor
In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi resolved LUCENE-2464.
------------------------------------
Fix Version/s: 3.1
Resolution: Fixed
trunk: Committed revision 960611.
branch_3x: Committed revision 960615.
> FastVectorHighlighter: add a FragmentBuilder to return entire field contents
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2464
> URL: https://issues.apache.org/jira/browse/LUCENE-2464
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2464.patch
>
>
> In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated LUCENE-2464:
-----------------------------------
Attachment: LUCENE-2464.patch
I implemented SingleFragListBuilder that generates one WeightedFragInfo object. Using both this class and SimpleFragmentsBuilder, you can get an entire field contents as described in Javadoc.
{code}
FastVectorHighlighter h = new FastVectorHighlighter( true, true,
new SingleFragListBuilder(), new SimpleFragmentsBuilder() );
{code}
SingleFragListBuilder ignores fragCharSize... I think createFieldFragList() shouldn't take fragCharSize argument (the necessity of fragCharSize depends on FragListBuilder impl). I want to change the interface in the future.
> FastVectorHighlighter: add a FragmentBuilder to return entire field contents
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2464
> URL: https://issues.apache.org/jira/browse/LUCENE-2464
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Reporter: Koji Sekiguchi
> Priority: Minor
> Attachments: LUCENE-2464.patch
>
>
> In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
Posted by "Lukas Vlcek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906709#action_12906709 ]
Lukas Vlcek commented on LUCENE-2464:
-------------------------------------
I found that even if the SingleFragListBuilder is used then client has explicitly ensure that numberOfFragments > 0 otherwise highlighter produces empty output.
The thing is that
{noformat} FastVectorHighlighter.getBestFragments( final FieldQuery fieldQuery, IndexReader reader, int docId, String fieldName, int fragCharSize, int maxNumFragments );{noformat}
delegates to
{noformat} BaseFragmentsBuilder.createFragments( IndexReader reader, int docId, String fieldName, FieldFragList fieldFragList, int maxNumFragments, String[] preTags, String[] postTags, Encoder encoder);{noformat}
which needs to be passed maxNumFragments > 0 in order to produce any non-empty output.
> FastVectorHighlighter: add a FragmentBuilder to return entire field contents
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2464
> URL: https://issues.apache.org/jira/browse/LUCENE-2464
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2464.patch
>
>
> In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi reassigned LUCENE-2464:
--------------------------------------
Assignee: Koji Sekiguchi
> FastVectorHighlighter: add a FragmentBuilder to return entire field contents
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2464
> URL: https://issues.apache.org/jira/browse/LUCENE-2464
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Attachments: LUCENE-2464.patch
>
>
> In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2464) FastVectorHighlighter: add a
FragmentBuilder to return entire field contents
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885112#action_12885112 ]
Koji Sekiguchi commented on LUCENE-2464:
----------------------------------------
I think this is ready to commit. Will commit shortly.
> FastVectorHighlighter: add a FragmentBuilder to return entire field contents
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2464
> URL: https://issues.apache.org/jira/browse/LUCENE-2464
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Reporter: Koji Sekiguchi
> Priority: Minor
> Attachments: LUCENE-2464.patch
>
>
> In Highlightrer, there is a Nullfragmenter. There is a requirement its counterpart in FastVectorhighlighter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org