[GitHub] [airflow] potiuk commented on pull request #31798: fix spark-kubernetes-operator compatibility

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #31798:
URL: https://github.com/apache/airflow/pull/31798#issuecomment-1594572974

   > > @jherrmannNetfonds Good catch buddy. Since with `watch=True` this operator is responsible for the execution, logs and states of the task, I believe in that case the pod/job should be killed, that's why I overwrited the `on_kill` method to kill it. But apparently the `on_kill` didn't work.
   > 
   > @potiuk I believe this behaviour that `on_kill` method did not invoke is because we only catch `AirflowTaskTimeout`
   > 
   > https://github.com/apache/airflow/blob/a60429eadfffb5fb0f867c220a6cecf628692dcf/airflow/models/taskinstance.py#L1709-L1718
   
   We run on_kill in local_task_runner:
   
   ```
           finally:
               self.on_kill()
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org