You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/02 12:15:15 UTC
[GitHub] [ozone] ayushtkn commented on a change in pull request #1814: HDDS-4650. Refactor ACL operation error handling
ayushtkn commented on a change in pull request #1814:
URL: https://github.com/apache/ozone/pull/1814#discussion_r585502534
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##########
@@ -431,10 +432,11 @@ public boolean addAcl(OzoneObj obj, OzoneAcl acl) throws IOException {
BUCKET_NOT_FOUND);
}
- changed = bucketInfo.addAcl(acl);
- if (changed) {
- metadataManager.getBucketTable().put(dbBucketKey, bucketInfo);
+ if (!bucketInfo.addAcl(acl)) {
+ throw new OMException("Add acl operation failed" + bucket,
+ ACL_ADD_FAILED);
Review comment:
Couldn't check again, Wei-Chiu if you are convinced, Please proceed, nothing blocking from my side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org