You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/10 10:36:48 UTC
[GitHub] [camel-k] squakez opened a new issue #2742: [E2E] Reconciliation duration metric failure
squakez opened a new issue #2742:
URL: https://github.com/apache/camel-k/issues/2742
I've noticed this since a while, not sure if we're tracking somewhere else already. Basically there seems to be some error in all the PRs (ie, https://github.com/apache/camel-k/runs/4163440983?check_suite_focus=true) due to:
```
--- FAIL: TestMetrics (100.50s)
--- PASS: TestMetrics/Build_duration_metric (0.02s)
--- PASS: TestMetrics/Build_recovery_attempts_metric (0.02s)
--- FAIL: TestMetrics/reconciliation_duration_metric (0.04s)
```
Having a look at the code, it seems it complains here: https://github.com/apache/camel-k/blob/main/e2e/common/operator_metrics_test.go#L256
Because it cannot match with the following:
```
TestMetrics/reconciliation_duration_metric
operator_metrics_test.go:256:
Expected
<string>: MetricFamily
to match fields: {
.Metric:
Expected
<[]*io_prometheus_client.Metric | len:8, cap:8>: [
{
Label: [
{
Name: "group",
Value: "camel.apache.org",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
{
Name: "kind",
Value: "Build",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
{
Name: "namespace",
Value: "test-d047b7ac-9a61-409a-b312-449c4ef86bfa",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
],
missingElements: [
<*io_prometheus_client.LabelPair | 0xc00080e120>{
Name: "version",
Value: "v1",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
<*io_prometheus_client.LabelPair | 0xc00080e150>{
Name: "kind",
Value: "Integration",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
],
extraElements: [
<*io_prometheus_client.LabelPair | 0xc00065f770>{
Name: "kind",
Value: "Kamelet",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
<*io_prometheus_client.LabelPair | 0xc00065f830>{
Name: "version",
Value: "v1alpha1",
XXX_NoUnkeyedLiteral: {},
XXX_unrecognized: nil,
XXX_sizecache: 0,
},
],
},
"Histogram": <*gstruct.PointerMatcher | 0xc0007b9840>{
Matcher: <*gstruct.FieldsMatcher | 0xc00080e240>{
Fields: {
...
Gomega truncated this representation as it exceeds 'format.MaxLength'.
Consider having the object provide a custom 'GomegaStringer' representation
or adjust the parameters in Gomega's 'format' package.
Learn more here: https://onsi.github.io/gomega/#adjusting-output
}
```
fyi @tadayosi @astefanutti @nicolaferraro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #2742:
URL: https://github.com/apache/camel-k/issues/2742#issuecomment-965943033
By the way, when we use Gomega's structural matches the diffs at test failure can be really lengthy and thus truncated by default. In the above case, the real mismatch is hidden in the truncated part.
If we are ok, probably we should add:
```
format.MaxLength = 0
```
somewhere in `test_support.go` to disable the diff truncation.
https://onsi.github.io/gomega/#adjusting-output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2742:
URL: https://github.com/apache/camel-k/issues/2742#issuecomment-989762507
Now that we don't truncate log, I can see the exact failure:
```
"Histogram": <*gstruct.PointerMatcher | 0xc0006c9740>{
Matcher: <*gstruct.FieldsMatcher | 0xc00066ed80>{
Fields: {
"SampleCount": <*gstruct.PointerMatcher | 0xc0006c9720>{
Matcher: <*matchers.EqualMatcher | 0xc000c5a500>{Expected: <uint64>12},
failure: "Expected\n <uint64>: 272\nto equal\n <uint64>: 12",
},
},
```
This is an excerpt from this failed build: https://github.com/apache/camel-k/runs/4446921484?check_suite_focus=true
Digging deeper:
```
Label: [
...
{
Name: "kind",
Value: "Kamelet",
...
{
Name: "result",
Value: "Reconciled",
...
},
...
],
...
Histogram: {
SampleCount: 272,
```
It seems that the reconciliation count for Kamelet is used instead of the Integration. We're probably counting wrong in the log. I'm trying to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #2742:
URL: https://github.com/apache/camel-k/issues/2742#issuecomment-966985852
@tadayosi I agree this would be useful 👍🏼.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #2742:
URL: https://github.com/apache/camel-k/issues/2742#issuecomment-965063937
FYI Antonin’s insight on the exact issue.
https://github.com/apache/camel-k/pull/2714#issuecomment-951677998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2742:
URL: https://github.com/apache/camel-k/issues/2742#issuecomment-965169728
> FYI Antonin’s insight on the exact issue. [#2714 (comment)](https://github.com/apache/camel-k/pull/2714#issuecomment-951677998)
I missed that, thanks. So, it seems that we need to keep this open and try to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti closed issue #2742: [E2E] Reconciliation duration metric failure
Posted by GitBox <gi...@apache.org>.
astefanutti closed issue #2742:
URL: https://github.com/apache/camel-k/issues/2742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org