You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/06/23 04:35:36 UTC

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1814: fix ssl state exception coredump

wwbmmm commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r904507854


##########
src/brpc/socket.h:
##########
@@ -747,6 +750,9 @@ friend void DereferenceSocket(Socket*);
     // Non-zero when health-checking is on.
     int _health_check_interval_s;
 
+    // true when client SocketMap has removed socket
+    butil::atomic<bool> _stop_health_check;

Review Comment:
   这个是不是不需要原子变量?
   因为读写这个变量的上下文 已经通过_versioned_ref原子变量进行了同步



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org