You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/26 01:48:46 UTC

[GitHub] andyh1203 commented on a change in pull request #4590: [AIRFLOW-3727] Change references of is_localized to is_aware

andyh1203 commented on a change in pull request #4590: [AIRFLOW-3727] Change references of is_localized to is_aware
URL: https://github.com/apache/airflow/pull/4590#discussion_r251182819
 
 

 ##########
 File path: airflow/api/common/experimental/mark_tasks.py
 ##########
 @@ -74,7 +74,7 @@ def set_state(task, execution_date, upstream=False, downstream=False,
     :param session: database session
     :return: list of tasks that have been created and updated
     """
-    assert timezone.is_localized(execution_date)
+    assert timezone.is_aware(execution_date)
 
 Review comment:
   Hey @feng-tao, `timezone.is_aware()` currently does not exist in the timezone file, but in my commit, I'm making a change to the timezone file as well where I rename the method to `is_aware`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services