[PR] KAFKA-17770: use Locale.ROOT when converting server config keys from env vars [kafka]

["atharvaHJoshi (via GitHub)" <gi...@apache.org>]

atharvaHJoshi opened a new pull request, #23775:
URL: https://github.com/apache/kafka/pull/23775

   KafkaDockerWrapper#getServerConfigsFromEnv lowercased the environment variable name using the system default Locale. Locales with different casing rules (for example Turkish/Azerbaijani, where 'I' lowercases to a dotless 'ı') therefore produced invalid server config keys from KAFKA_* environment variables.
   
   This change uses Locale.ROOT so the conversion is independent of the system default Locale. This is one of the remaining instances of the locale sensitivity described in KAFKA-17770.
   
   ### Testing
   - Added KafkaDockerWrapperTest#testGetServerConfigsFromEnvWithLocaleSensitiveCaseMapping, which sets the default Locale to tr-TR and asserts the resulting key is inter.broker.listener.name (fails before the fix).
   - `./gradlew :core:test --tests "kafka.docker.KafkaDockerWrapperTest"`
   - `./gradlew :core:spotlessCheck :core:checkstyleMain`
   
   Generated-by: opencode (big-pickle)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17770: use Locale.ROOT when converting server config keys from env vars [kafka]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #23775:
URL: https://github.com/apache/kafka/pull/23775#issuecomment-6307208710

   A label of 'needs-attention' was automatically added to this PR in order to raise the
   attention of the committers. Once this issue has been triaged, the `triage` label
   should be removed to prevent this automation from happening again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org