You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/22 05:15:35 UTC
[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1255: chore(deps): bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1 in /test/e2e
dependabot[bot] opened a new pull request, #1255:
URL: https://github.com/apache/apisix-ingress-controller/pull/1255
Bumps [github.com/eclipse/paho.mqtt.golang](https://github.com/eclipse/paho.mqtt.golang) from 1.3.5 to 1.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eclipse/paho.mqtt.golang/releases">github.com/eclipse/paho.mqtt.golang's releases</a>.</em></p>
<blockquote>
<h2>v1.4.1</h2>
<p>The license update in v1.4.0 included changes which prevented <a href="https://pkg.go.dev">https://pkg.go.dev</a> from displaying the documentation. The only change in this release is to update LICENSE such that it includes the full test of the Eclipse Public License v2.0 (tested this on a fork and it appears to resolve the issue).</p>
<h2>v1.4.0</h2>
<p>In the year since the release of v1.3.5 the majority of changes have been small incremental improvements/fixes. It is worth noting that the library has moved to the EPL v2.0 license (<a href="https://www.eclipse.org/legal/epl-2.0/faq.php">faq</a>).</p>
<p>A few new features have been added:</p>
<ul>
<li>Managing the connection to the broker can become involved (e.g. setting unusual TCP/TLS options, need for a non-standard TLS library, require a specific web-socket library etc) and the library already has too many options! To address this a new option, <code>SetCustomOpenConectionFn</code>, has been added that enables users to provide a function (<code>func(uri *url.URL, options ClientOptions) (net.Conn, error)</code>) that will be called to establish a connection (replacing the inbuilt code). This should enable edge cases to be addressed without the need for further changes to this library.</li>
<li>When connecting/reconnecting it is possible that there will be a lot of packets queued; in the past the library sent all of these packets as rapidly as possible when the connection came up. However this could saturate some network links causing the connection to drop (a vicious circle). The new option <code>SetMaxResumePubInFlight</code> allows a limit to be imposed; the library will send out the requested number of packets and then wait for acknowledgements before sending more (only applicable at QOS1+).</li>
</ul>
<p>Thanks to everyone who submitted issues and contributed code (list of the main merged pull requests below):</p>
<h2>What's Changed</h2>
<ul>
<li>SetMaxResumePubInFlight option - limit inflight publish packets on resume by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/521">eclipse/paho.mqtt.golang#521</a></li>
<li>Test for PR 521 (forgot to commit) by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/522">eclipse/paho.mqtt.golang#522</a></li>
<li>Dont panic if there are files with short names in the file store folder. by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/523">eclipse/paho.mqtt.golang#523</a></li>
<li>Add license headers to all files and move from EPL v1.0 to EPL v2.0 by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/524">eclipse/paho.mqtt.golang#524</a> / <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/525">eclipse/paho.mqtt.golang#525</a></li>
<li>Add warning to Disconnect function by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/537">eclipse/paho.mqtt.golang#537</a></li>
<li>Use uri.Path instead of uri.Host for UNIX domain socket URLs by <a href="https://github.com/webconn"><code>@webconn</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/540">eclipse/paho.mqtt.golang#540</a></li>
<li>CodeQL & integer conversion fix by <a href="https://github.com/jfcg"><code>@jfcg</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/541">eclipse/paho.mqtt.golang#541</a></li>
<li>Mosquitto related changes (updated config and comments). by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/546">eclipse/paho.mqtt.golang#546</a></li>
<li>README enhancements by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/547">eclipse/paho.mqtt.golang#547</a> / <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/548">eclipse/paho.mqtt.golang#548</a></li>
<li>Improve handling of SUBSCRIBE/UNSUBSCRIBE over disconnect/reconnect. by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/557">eclipse/paho.mqtt.golang#557</a></li>
<li>log err.error() if ConnectRetry is enabled by <a href="https://github.com/TomasVojacek"><code>@TomasVojacek</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/558">eclipse/paho.mqtt.golang#558</a></li>
<li>Add tcp option to set keep alive value on the tcp layer by <a href="https://github.com/mogaleaf"><code>@mogaleaf</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/561">eclipse/paho.mqtt.golang#561</a></li>
<li>Document token.Wait behaviour during reconnect by <a href="https://github.com/ecksun"><code>@ecksun</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/565">eclipse/paho.mqtt.golang#565</a></li>
<li>Custom open connection for different network types by <a href="https://github.com/GilGil1"><code>@GilGil1</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/574">eclipse/paho.mqtt.golang#574</a> / <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/575">eclipse/paho.mqtt.golang#575</a></li>
<li>nil c.options.Dialer caused a panic. by <a href="https://github.com/MattBrittan"><code>@MattBrittan</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/577">eclipse/paho.mqtt.golang#577</a></li>
<li>Disconnect refactor by <a href="https://github.com/ptsneves"><code>@ptsneves</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/586">eclipse/paho.mqtt.golang#586</a></li>
<li>client.go Remove Disconnect()'s wait on c.commsStopped. by <a href="https://github.com/ptsneves"><code>@ptsneves</code></a> in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/590">eclipse/paho.mqtt.golang#590</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/webconn"><code>@webconn</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/540">eclipse/paho.mqtt.golang#540</a></li>
<li><a href="https://github.com/jfcg"><code>@jfcg</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/541">eclipse/paho.mqtt.golang#541</a></li>
<li><a href="https://github.com/TomasVojacek"><code>@TomasVojacek</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/558">eclipse/paho.mqtt.golang#558</a></li>
<li><a href="https://github.com/mogaleaf"><code>@mogaleaf</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/561">eclipse/paho.mqtt.golang#561</a></li>
<li><a href="https://github.com/ecksun"><code>@ecksun</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/565">eclipse/paho.mqtt.golang#565</a></li>
<li><a href="https://github.com/GilGil1"><code>@GilGil1</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/574">eclipse/paho.mqtt.golang#574</a></li>
<li><a href="https://github.com/ptsneves"><code>@ptsneves</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/pull/586">eclipse/paho.mqtt.golang#586</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/eclipse/paho.mqtt.golang/compare/v1.3.5...v1.4.0">https://github.com/eclipse/paho.mqtt.golang/compare/v1.3.5...v1.4.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/bcb58ee4a1782dd29e40cc37230a1f8a31df1376"><code>bcb58ee</code></a> Update license to meet pkg.go.dev requirements</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/87173763ce056ff2dd4e61c01efae663539178e8"><code>8717376</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/issues/590">#590</a> from ptsneves/pneves-disconnect-workaround</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/2e835828b520864c49cd2771de9505156854e75c"><code>2e83582</code></a> client.go Remove Disconnect()'s wait on c.commsStopped.</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/eaac59be2a8aeba85b346a04b7ee65d914e5fe6d"><code>eaac59b</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/issues/586">#586</a> from ptsneves/disconnect-refactor</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/ac29fdf5dbd9840c81414431062955c4ae3d1cef"><code>ac29fdf</code></a> client: localized disconnectSent logic</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/3ec7db339d21308d4baaa028e9e2cce2759877d6"><code>3ec7db3</code></a> client: refactor setConnected(disconnected) out of conditional</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/7254d2c9d75a30fe034918752ab04e94f973b12d"><code>7254d2c</code></a> client: set disconnect as defer</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/2d3b04d5b874851cf7e76f51987492393c88e258"><code>2d3b04d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/issues/577">#577</a> from ChIoT-Tech/master</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/721bf9fa7789cf99251c4cd40fc15764dcc77773"><code>721bf9f</code></a> If c.options.Dialer was nil this caused a panic.</li>
<li><a href="https://github.com/eclipse/paho.mqtt.golang/commit/44f71c7c3ea71ef46077c5a400319ce717d7cbf1"><code>44f71c7</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/eclipse/paho.mqtt.golang/issues/575">#575</a> from GilGil1/master</li>
<li>Additional commits viewable in <a href="https://github.com/eclipse/paho.mqtt.golang/compare/v1.3.5...v1.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1255: chore(deps): bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1 in /test/e2e
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1255:
URL: https://github.com/apache/apisix-ingress-controller/pull/1255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1255: chore(deps): bump github.com/eclipse/paho.mqtt.golang from 1.3.5 to 1.4.1 in /test/e2e
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1255:
URL: https://github.com/apache/apisix-ingress-controller/pull/1255#issuecomment-1221852614
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1255](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1255?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff9d6ec) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/530ce52b278d7e385db3747d33e0d9fe1db0f3d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (530ce52) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 42.72% 42.72%
=======================================
Files 73 73
Lines 6486 6486
=======================================
Hits 2771 2771
Misses 3418 3418
Partials 297 297
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org