You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2008/05/16 13:27:55 UTC
[jira] Created: (HADOOP-3405) Make mapred internal classes
package-local
Make mapred internal classes package-local
------------------------------------------
Key: HADOOP-3405
URL: https://issues.apache.org/jira/browse/HADOOP-3405
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Affects Versions: 0.18.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
Fix For: 0.18.0
In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Attachment: post-544_v1.patch
This patch refactors the 4 classes into package-local scope, and also fixes the backwards compatibility problem, erroneously introduced in HADOOP-544(in JobProfile and JobStatus classes).
The change in JobSubmissionProtocol clearly breaks pig and possibly others, but the protocol is really internal(see HADOOP-1643).
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Status: Open (was: Patch Available)
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3405:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change])
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Enis!
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Status: Patch Available (was: Open)
Retrying hudson, the tests failed due to dfs problems.
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Status: Patch Available (was: Open)
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597499#action_12597499 ]
Hadoop QA commented on HADOOP-3405:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382163/post-544_v1.patch
against trunk revision 656939.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2487/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2487/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2487/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2487/console
This message is automatically generated.
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598896#action_12598896 ]
Hadoop QA commented on HADOOP-3405:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382163/post-544_v1.patch
against trunk revision 658862.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2514/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2514/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2514/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2514/console
This message is automatically generated.
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3405:
------------------------------------
Release Note: Refactored previously public classes MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore to be package local. (was: This issue refactors previously public classes : MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore to be package local. )
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Status: Patch Available (was: Open)
local tests pass, retrying for the third time !
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597556#action_12597556 ]
Hadoop QA commented on HADOOP-3405:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382163/post-544_v1.patch
against trunk revision 656939.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2489/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2489/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2489/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2489/console
This message is automatically generated.
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599346#action_12599346 ]
Hudson commented on HADOOP-3405:
--------------------------------
Integrated in Hadoop-trunk #500 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/500/])
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3405) Make mapred internal classes
package-local
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3405:
----------------------------------
Status: Open (was: Patch Available)
> Make mapred internal classes package-local
> ------------------------------------------
>
> Key: HADOOP-3405
> URL: https://issues.apache.org/jira/browse/HADOOP-3405
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.18.0
>
> Attachments: post-544_v1.patch
>
>
> In the work for HADOOP-544, we have realized that some of the public classes in the mapred package should have package-local scope. The classes which are public, but should not be, are :
> MapTaskStatus, ReduceTaskStatus, JobSubmissionProtocol, CompletedJobStatusStore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.