You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2018/10/25 13:50:52 UTC
[GitHub] zookeeper pull request #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeepe...
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/682
ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
Mark the test as ignored.
Please see https://issues.apache.org/jira/browse/ZOOKEEPER-3182 for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2807
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/682.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #682
----
commit 3c6475b1968e14a0db276286d6abc9f595a37ba8
Author: Andor Molnar <an...@...>
Date: 2018-10-25T13:47:40Z
ZOOKEEPER-2807. Ignore failing unit tests, because it indicates a potential bug
----
---
[GitHub] zookeeper pull request #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeepe...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/682#discussion_r228315225
--- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java ---
@@ -95,6 +96,7 @@ public void setUp() {
}
@Test
+ @Ignore("ZOOKEEPER-3182")
--- End diff --
As I mentioned in the Jira, I don't think this is a ZK code problem, but we should improve the reliability in this test case, if the client is disconnected we cannot guarantee it will get the 'expected' watch event without doing sync first.
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/682
Thanks @anmolnar, I've merged this onto master.
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
retest this please
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
If there's no objection, I'll get this in tomorrow.
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/682
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2520/
---
[GitHub] zookeeper pull request #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeepe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/682
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
@lvfangmin Moved bunch of common code to Before/After.
Also changed the logic to call `setData` in order to verify `NodeDataChanged` event.
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/682
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2509/
---
[GitHub] zookeeper pull request #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeepe...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/682#discussion_r228334877
--- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java ---
@@ -95,6 +96,7 @@ public void setUp() {
}
@Test
+ @Ignore("ZOOKEEPER-3182")
--- End diff --
Replied on the jira.
---
[GitHub] zookeeper issue #682: ZOOKEEPER-2807. Flaky test: org.apache.zookeeper.test....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/682
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2519/
---