You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/19 12:16:10 UTC
[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
bartekkuncer opened a new pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679
## Description ##
This change adds aliases for subgraph operators to be compatible with old saves of mxnet models.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#issuecomment-946662359
Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, windows-cpu, miscellaneous, unix-gpu, clang, unix-cpu, website, edge, centos-gpu, sanity, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#issuecomment-950580398
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r731946609
##########
File path: src/operator/subgraph/dnnl/dnnl_post_quantize_property.h
##########
@@ -56,7 +56,7 @@ class SgDNNLPostQuantizeSelector : public SubgraphSelector {
bool Select(const nnvm::Node& n) override {
if (n.op() && support_requantize_fusion_op_name.count(n.op()->name)) {
- if (n.op()->name == "_sg_onednn_conv" || n.op()->name == "_sg_mkldnn_conv") {
+ if (n.op()->name == "_sg_onednn_conv") {
Review comment:
Here as we compare names both version (ondednn|mkldnn) should be checked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#issuecomment-950580329
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r732215277
##########
File path: src/operator/subgraph/dnnl/dnnl_post_quantize_property.h
##########
@@ -56,7 +56,7 @@ class SgDNNLPostQuantizeSelector : public SubgraphSelector {
bool Select(const nnvm::Node& n) override {
if (n.op() && support_requantize_fusion_op_name.count(n.op()->name)) {
- if (n.op()->name == "_sg_onednn_conv" || n.op()->name == "_sg_mkldnn_conv") {
+ if (n.op()->name == "_sg_onednn_conv") {
Review comment:
@bgawrych and also will be consistent with all the other comparisons, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r731847297
##########
File path: src/operator/subgraph/dnnl/dnnl_transformer_post_quantize_property.h
##########
@@ -53,7 +53,9 @@ class SgDNNLTransformerPostQuantizeSelector : public SubgraphSelector {
bool Select(const nnvm::Node& n) override {
if ((!disable_all) && (n.op() == Op::Get("_sg_onednn_selfatt_qk") ||
- n.op() == Op::Get("_sg_onednn_selfatt_valatt"))) {
+ n.op() == Op::Get("_sg_onednn_selfatt_valatt") ||
Review comment:
one from the each pair is only needed
##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -187,7 +187,8 @@ inline QuantizeType NeedQuantize(ObjectPtr node,
need = false;
if (need) {
if ((quantize_granularity == "channel-wise") &&
- (node->op() == Op::Get("_sg_onednn_fully_connected"))) {
+ (node->op() == Op::Get("_sg_onednn_fully_connected") ||
Review comment:
both Op::Get return the same operator - please use only one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#issuecomment-950683785
@szha Please help with the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
bgawrych commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r732027694
##########
File path: src/operator/subgraph/dnnl/dnnl_post_quantize_property.h
##########
@@ -56,7 +56,7 @@ class SgDNNLPostQuantizeSelector : public SubgraphSelector {
bool Select(const nnvm::Node& n) override {
if (n.op() && support_requantize_fusion_op_name.count(n.op()->name)) {
- if (n.op()->name == "_sg_onednn_conv" || n.op()->name == "_sg_mkldnn_conv") {
+ if (n.op()->name == "_sg_onednn_conv") {
Review comment:
n.op() == Op::Get("...") should deal with both comparisions in single one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r731978723
##########
File path: src/operator/subgraph/dnnl/dnnl_post_quantize_property.h
##########
@@ -56,7 +56,7 @@ class SgDNNLPostQuantizeSelector : public SubgraphSelector {
bool Select(const nnvm::Node& n) override {
if (n.op() && support_requantize_fusion_op_name.count(n.op()->name)) {
- if (n.op()->name == "_sg_onednn_conv" || n.op()->name == "_sg_mkldnn_conv") {
+ if (n.op()->name == "_sg_onednn_conv") {
Review comment:
Good catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org