You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/08 03:08:50 UTC

[GitHub] [apisix] wfgydbu commented on issue #2985: bug: 'limit-conn' plugin seems working in an unexpected manner

wfgydbu commented on issue #2985:
URL: https://github.com/apache/apisix/issues/2985#issuecomment-740344661


   https://github.com/apache/apisix/blob/v2.1/apisix/plugins/limit-conn.lua#L88-L94
   
   I think these code should be something like this:
   ```
       if lim:is_committed() then
           if not ctx.limit_conn then
               ctx.limit_conn = core.tablepool.fetch("plugin#limit-conn", 0, 6)
   
           core.table.insert_tail(ctx.limit_conn, lim, key, delay)
           end
       end
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org