You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/05 12:10:39 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #6369: Fix in default syslog date format.

fjpanag opened a new pull request, #6369:
URL: https://github.com/apache/incubator-nuttx/pull/6369

   ## Summary
   
   When `SYSLOG_TIMESTAMP_FORMATTED` is selected, `SYSLOG_TIMESTAMP_FORMAT` is used to format the date that syslog will print.
   
   Although the formatting is configurable by the user, I believe that the default setting is not optimal.
   
   It is inconsistent, as all numbers printed are zero-padded *except* the day.  
   This PR changes the default format, making the day of the month also zero-padded.
   
   This is a more sane and consistent default.
   
   
   ## Impact
   
   The default syslog date format is more consistent.  
   This default change should not harm any system, or cause any side effect, and can be configured by the user back to what it was before.
   
   
   ## Testing
   
   Tested on a custom STM32F4 target on a serial logger.
   
   Example logs:
   
   Before:
   ```
   [ 5/06/22 12:07:01] [ 4] [  INFO] Bootloader status: [NO ACTION - 0x0000]
   [ 5/06/22 12:07:01] [ 4] [  INFO] SD card mounted.
   [ 5/06/22 12:07:01] [ 5] [  INFO] Loading settings...
   ```
   
   After:
   
   ```
   [05/06/22 12:05:22] [ 4] [  INFO] Bootloader status: [NO ACTION - 0x0000]
   [05/06/22 12:05:22] [ 4] [  INFO] SD card mounted.
   [05/06/22 12:05:22] [ 5] [  INFO] Loading settings...
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6369: Fix in default syslog date format.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6369:
URL: https://github.com/apache/incubator-nuttx/pull/6369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org