You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/11 13:39:11 UTC
[PR] fix: surface metrics errors and replace deprecated input API [rocketmq-dashboard]
Aias00 opened a new pull request, #1771:
URL: https://github.com/apache/rocketmq-dashboard/pull/1771
## Summary
- display the actionable error message returned by the metrics query API while retaining a localized fallback for unstructured failures
- replace the deprecated `InputNumber.addonAfter` usage with a `Space.Compact` session-timeout field and read-only unit input
- add focused regression coverage for both behaviors
Closes #1765
## Validation
- `npm run test -- src/components/__tests__/MetricsExplorer.test.tsx src/pages/settings/__tests__/GeneralSettingsTab.test.tsx`
- `npm run build`
- `npm run lint` *(blocked by an existing `BrokerCluster.tsx` React hooks error on the current base branch; changed files are clean)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: surface metrics errors and replace deprecated input API [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1771:
URL: https://github.com/apache/rocketmq-dashboard/pull/1771#issuecomment-5266903421
Superseded by #1966 and #1908. The actionable Metrics Explorer error handling is now in #1966, while the General Settings Ant Design migration is now in #1908. Issue #1765 remains referenced by both PRs until both halves merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: surface metrics errors and replace deprecated input API [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #1771: fix: surface metrics errors and replace deprecated input API
URL: https://github.com/apache/rocketmq-dashboard/pull/1771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org