You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/06 03:31:44 UTC

[GitHub] [flink] mayuehappy commented on a diff in pull request #19259: [FLINK-23890] improve cep operator timer register policy

mayuehappy commented on code in PR #19259:
URL: https://github.com/apache/flink/pull/19259#discussion_r843427786


##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/CepOperator.java:
##########
@@ -417,6 +405,9 @@ private void processEvent(NFAState nfaState, IN event, long timestamp) throws Ex
                             timestamp,
                             afterMatchSkipStrategy,
                             cepTimerService);
+            if (nfa.getWindowTime() > 0 && nfaState.isNewStartPartialMatch()) {
+                registerTimer(timestamp + nfa.getWindowTime());

Review Comment:
   In my understanding, if there is a window in NFA then we need to register a timer to trigger this window. But if there is no window, what is the purpose of registering the timer of current watermark +1 here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org