You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2011/04/01 18:33:05 UTC

[jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit

    [ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014722#comment-13014722 ] 

Kathey Marsden commented on DERBY-5127:
---------------------------------------

I think the new patch looks fine except that the fixture throws an Exception instead of SQLException. Also the master/madhare.out (master file) needs to be removed with svn delete.  I will commit with these two small changes.  Normally I would say it would be good to have javadoc for each fixture but since this test just has one and there are comments in the class comments, I think that is ok.  For future conversions, however make sure each fixture has javadoc.



> Convert madhare.sql to JUnit
> ----------------------------
>
>                 Key: DERBY-5127
>                 URL: https://issues.apache.org/jira/browse/DERBY-5127
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Siddharth Srivastava
>            Assignee: Siddharth Srivastava
>            Priority: Minor
>         Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff
>
>
> Convert madhare.sql to JUnit

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira