You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/01 15:56:21 UTC

[GitHub] [flink] blublinsky opened a new pull request #14283: FLINK-15649 Support mounting volumes

blublinsky opened a new pull request #14283:
URL: https://github.com/apache/flink/pull/14283


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   This pull request let user can mount customized volume to JobManager or TaskManager pod.
   
   ## Brief change log
   
   And the MountVolumesDecorator set the Volume and the VolumeMount to the given pod and container.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Added test that validates MountVolumesDecorator mounting volume correctly.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes 
     - If yes, how is the feature documented?  JavaDocs 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14283: FLINK-15649 Support mounting volumes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-736675395


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10404",
       "triggerID" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bf7d5e41e38d9dbeef734ccb80f97fe948974837",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10413",
       "triggerID" : "bf7d5e41e38d9dbeef734ccb80f97fe948974837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bf7d5e41e38d9dbeef734ccb80f97fe948974837 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10413) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] binygreenberg commented on a change in pull request #14283: [FLINK-15649] Support mounting volumes

Posted by GitBox <gi...@apache.org>.
binygreenberg commented on a change in pull request #14283:
URL: https://github.com/apache/flink/pull/14283#discussion_r548501163



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/VolumeMountDecorator.java
##########
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.kubeclient.decorators;
+
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.kubernetes.kubeclient.FlinkPod;
+import org.apache.flink.kubernetes.kubeclient.parameters.AbstractKubernetesParameters;
+
+import io.fabric8.kubernetes.api.model.Container;
+import io.fabric8.kubernetes.api.model.ContainerBuilder;
+import io.fabric8.kubernetes.api.model.Pod;
+import io.fabric8.kubernetes.api.model.PodBuilder;
+import io.fabric8.kubernetes.api.model.Quantity;
+import io.fabric8.kubernetes.api.model.Volume;
+import io.fabric8.kubernetes.api.model.VolumeBuilder;
+import io.fabric8.kubernetes.api.model.VolumeMount;
+import io.fabric8.kubernetes.api.model.VolumeMountBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Arrays;
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * Mounts volumes on the JobManager or TaskManager pod. Volumes can be PVC, empty dir and host path
+ * All resources are assumed to exist.
+ * Resource definition is contained in FlinkConfiguration as follows:
+ *  for job manager:
+ * 			volumekey = "kubernetes.jobmanager.volumemount"
+ * 	for task manager:
+ * 			volumekey = "kubernetes.taskmanager.vlumemount"

Review comment:
       nit: spelling




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14283: FLINK-15649 Support mounting volumes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-736645552


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ca7d9b637e2ac020049e3a54b80ba6a14b9f7865 (Tue Dec 01 15:59:20 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15649).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #14283: [FLINK-15649] Support mounting volumes

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-778993856


   I assume we can close this PR, because it is subsumed by FLINK-15656.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann closed pull request #14283: [FLINK-15649] Support mounting volumes

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14283:
URL: https://github.com/apache/flink/pull/14283


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14283: FLINK-15649 Support mounting volumes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-736675395


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10404",
       "triggerID" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bf7d5e41e38d9dbeef734ccb80f97fe948974837",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bf7d5e41e38d9dbeef734ccb80f97fe948974837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca7d9b637e2ac020049e3a54b80ba6a14b9f7865 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10404) 
   * bf7d5e41e38d9dbeef734ccb80f97fe948974837 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14283: FLINK-15649 Support mounting volumes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-736675395


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca7d9b637e2ac020049e3a54b80ba6a14b9f7865 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14283: FLINK-15649 Support mounting volumes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-736675395


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10404",
       "triggerID" : "ca7d9b637e2ac020049e3a54b80ba6a14b9f7865",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca7d9b637e2ac020049e3a54b80ba6a14b9f7865 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10404) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on pull request #14283: [FLINK-15649] Support mounting volumes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14283:
URL: https://github.com/apache/flink/pull/14283#issuecomment-784306956


   Closing the PR because it seems to be subsumed by #14629.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org