You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/23 20:16:47 UTC

[GitHub] [arrow-rs] nevi-me commented on a diff in pull request #1855: support compression for IPC

nevi-me commented on code in PR #1855:
URL: https://github.com/apache/arrow-rs/pull/1855#discussion_r905418959


##########
arrow/Cargo.toml:
##########
@@ -60,7 +63,7 @@ multiversion = { version = "0.6.1", default-features = false }
 bitflags = { version = "1.2.1", default-features = false }
 
 [features]
-default = ["csv", "ipc", "test_utils"]
+default = ["csv", "ipc", "test_utils", "zstd", "lz4"]

Review Comment:
    I'd be in favour of supporting `ipc` but not `ipc_compression` separately. The inconvenience of a larger binary is a lesser problem than the runtime error of not supporting compression by omission.
   The latter would need a rebuild.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org