You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/20 23:42:27 UTC

[GitHub] incubator-beam pull request: [BEAM-22] Allow InProcess Evaluators ...

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/220

    [BEAM-22] Allow InProcess Evaluators to check Side Input completion

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This checks to ensure that the PCollectionView in the SideInputWindow
    for the provided window either has elements available or is empty.
    
    Schedule a future to ensure that the SideInputWindows are appropriately
    filled with an empty iterable after retreiving the element.
    
    This is allows the ParDoEvaluator to not attempt to process elements
    that cannot currently be completed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam ippr_side_input_is_ready

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit ffc47d7b1367659fba36a17e477a510adb1d54f7
Author: Thomas Groh <tg...@google.com>
Date:   2016-04-18T23:16:48Z

    Allow InProcess Evaluators to check Side Input completion
    
    This checks to ensure that the PCollectionView in the SideInputWindow
    for the provided window either has elements available or is empty.
    
    Schedule a future to ensure that the SideInputWindows are appropriately
    filled with an empty iterable after retreiving the element.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request: [BEAM-22] Allow InProcess Evaluators ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---