[Impala-ASF-CR] IMPALA-9126: part 4: hash join builder manages spilling

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Hello Thomas Tauber-Marshall, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14790

to look at the new patch set (#8).

Change subject: IMPALA-9126: part 4: hash join builder manages spilling
......................................................................

IMPALA-9126: part 4: hash join builder manages spilling

This is the final patch for IMPALA-9126.

This will allow the many:1 relationship of probe:build
partitions that we need for the shared join build.

Key changes:
* Builder picks the next spilled partition to process.
* Partitions are identified by unique ID so can be
  decoupled between build and probe.
* unique_ptr is used to manage build partitions. This
  helps document the lifecycle of the partitions better,
  particularly when they are handed off to
  PartitionedHashJoinNode.

Testing:
* Ran exhaustive tests.
* Ran a single node TPC-H and TPC-DS stress test with 1000 queries.

Perf:
Ran a single node TPC-H 30 test against master from
before IMPALA-9126 changes. No significant perf
change.

Change-Id: I6de5f62e3eacf80f72c8ea0ed8cba012f0f53c90
---
M be/src/exec/partitioned-hash-join-builder-ir.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node-ir.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
6 files changed, 179 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/14790/8
-- 
To view, visit http://gerrit.cloudera.org:8080/14790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6de5f62e3eacf80f72c8ea0ed8cba012f0f53c90
Gerrit-Change-Number: 14790
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>