You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/25 17:10:49 UTC

[GitHub] [tvm] tkonolige commented on pull request #11391: [VM] Memory alignment check for `set_input` in Virtual Machine

tkonolige commented on PR #11391:
URL: https://github.com/apache/tvm/pull/11391#issuecomment-1137574311

   @vvchernov I see that you are still changing the semantics of `FromExternalDLTensor`. `FromExternalDLTensor(DLTensor* dl_tensor, const Device& dst_dev)` will copy if alignment is wrong, but `FromExternalDLTensor(const DLTensor& dl_tensor)` will throw an error if the alignment is wrong. I think this is pretty confusing as they both have the same name. Can you make `FromExternalDLTensor(DLTensor* dl_tensor, const Device& dst_dev)` fail if alignment is wrong and instead move the copying logic into the VM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org