You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/10/13 05:39:47 UTC

Review Request 73651: RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73651/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3478
    https://issues.apache.org/jira/browse/RANGER-3478


Repository: ranger


Description
-------

RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java ec9dc4bf6 
  agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 19878565c 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java b5967e4f7 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerJSONAuditWriter.java f46e0a578 


Diff: https://reviews.apache.org/r/73651/diff/1/


Testing
-------

- Verified in local vm with HDFS and HIVE service logs


Thanks,

Ramesh Mani


Re: Review Request 73651: RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73651/
-----------------------------------------------------------

(Updated Oct. 19, 2021, 6:46 a.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fixed review comments


Bugs: RANGER-3478
    https://issues.apache.org/jira/browse/RANGER-3478


Repository: ranger


Description
-------

RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java ec9dc4bf6 
  agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 19878565c 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java b5967e4f7 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerJSONAuditWriter.java f46e0a578 


Diff: https://reviews.apache.org/r/73651/diff/2/

Changes: https://reviews.apache.org/r/73651/diff/1-2/


Testing
-------

- Verified in local vm with HDFS and HIVE service logs


Thanks,

Ramesh Mani


Re: Review Request 73651: RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73651/#review223612
-----------------------------------------------------------


Fix it, then Ship it!





agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
Line 338 (original), 338 (patched)
<https://reviews.apache.org/r/73651/#comment312714>

    Consider moving #338 to #308, as these lines are needed only to format message used in LOG.debug().


- Madhan Neethiraj


On Oct. 13, 2021, 5:39 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73651/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2021, 5:39 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3478
>     https://issues.apache.org/jira/browse/RANGER-3478
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3478:Remove INFO level auditing logs in the Ranger audit frame to reduce verbosity
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java ec9dc4bf6 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 19878565c 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java b5967e4f7 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerJSONAuditWriter.java f46e0a578 
> 
> 
> Diff: https://reviews.apache.org/r/73651/diff/1/
> 
> 
> Testing
> -------
> 
> - Verified in local vm with HDFS and HIVE service logs
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>