You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "spebern (via GitHub)" <gi...@apache.org> on 2023/03/06 18:17:00 UTC

[GitHub] [arrow-rs] spebern commented on a diff in pull request #3805: Support reading decimal arrays from json

spebern commented on code in PR #3805:
URL: https://github.com/apache/arrow-rs/pull/3805#discussion_r1126846409


##########
arrow-json/src/reader.rs:
##########
@@ -1019,6 +1019,72 @@ impl Decoder {
         ))
     }
 
+    fn build_decimal128_array(

Review Comment:
   I have noticed it. The json reader is used in https://github.com/delta-io/delta-rs/tree/main/rust with the serde `Value` arguments. Maybe I can find some time to integrate the new interface, but for now it would already help if decimals were supported in the old decoder.
   
   Thank you for your time to review it and point me to the locations of adding the parsing logic. I mostly moved it out of `arrow-csv`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org