You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4net-dev@logging.apache.org by jasonwilliams200OK <gi...@git.apache.org> on 2016/07/13 10:17:56 UTC

[GitHub] log4net pull request #16: (LOG4NET-467) .NET Core support

Github user jasonwilliams200OK commented on a diff in the pull request:

    https://github.com/apache/log4net/pull/16#discussion_r70599902
  
    --- Diff: src/Appender/AppenderCollection.cs ---
    @@ -26,7 +26,10 @@ namespace log4net.Appender
     	/// A strongly-typed collection of <see cref="IAppender"/> objects.
     	/// </summary>
     	/// <author>Nicko Cadell</author>
    -	public class AppenderCollection : ICollection, IList, IEnumerable, ICloneable
    +	public class AppenderCollection : ICollection, IList, IEnumerable
    +#if !NETSTANDARD1_3
    +		, ICloneable
    --- End diff --
    
    Note that ICloneable is coming back. https://github.com/dotnet/corefx/pull/9970
    If the new contract doesn't support NETSTANDARD1_3, and we do want to support this TxM, then the best way in the future would be to also add `NETSTANDARD1_<whatever>` in the project.json which exposes IColeable interface on public surface area.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---