You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zachliu (via GitHub)" <gi...@apache.org> on 2023/05/01 23:15:50 UTC
[GitHub] [airflow] zachliu opened a new pull request, #31003: fix incorrect logic
zachliu opened a new pull request, #31003:
URL: https://github.com/apache/airflow/pull/31003
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Closes https://github.com/apache/airflow/issues/30997
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu closed pull request #31003: fix incorrect logic
Posted by "zachliu (via GitHub)" <gi...@apache.org>.
zachliu closed pull request #31003: fix incorrect logic
URL: https://github.com/apache/airflow/pull/31003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu commented on pull request #31003: fix incorrect logic
Posted by "zachliu (via GitHub)" <gi...@apache.org>.
zachliu commented on PR #31003:
URL: https://github.com/apache/airflow/pull/31003#issuecomment-1530549027
accidentally closed it :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu commented on pull request #31003: fix incorrect logic
Posted by "zachliu (via GitHub)" <gi...@apache.org>.
zachliu commented on PR #31003:
URL: https://github.com/apache/airflow/pull/31003#issuecomment-1530549652
if `State.finished` + `State.unfinished` == all possible states, then i can change it to
```python
if ti.state in State.finished
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu closed pull request #31003: fix incorrect logic
Posted by "zachliu (via GitHub)" <gi...@apache.org>.
zachliu closed pull request #31003: fix incorrect logic
URL: https://github.com/apache/airflow/pull/31003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org