[GitHub] [pulsar] eolivelli commented on a change in pull request #10797: fix transaction pending ack generate managedLedgerStats fail exception.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10797:
URL: https://github.com/apache/pulsar/pull/10797#discussion_r644561195



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java
##########
@@ -66,7 +67,7 @@ public static void generate(PulsarService pulsar, SimpleTextOutputStream stream,
                                     generateManageLedgerStats(managedLedger,
                                             stream, cluster, namespace, name, subscription.getName());
                                 } catch (Exception e) {
-                                    throw new IOException("Transaction pending ack generate managedLedgerStats fail!");
+                                    log.warn("Transaction pending ack generate managedLedgerStats fail!", e);

Review comment:
       Did you investigate the root cause of the exception ?
   
   I am fine with committing this patch, but we should understand the cause.
   It is unfortunate that we are not adding the exception as "cause" to the IOException
   
   can you investigate more ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org