You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/05/11 21:38:52 UTC

[GitHub] [pinot] shenyu0127 commented on issue #10749: Case insensitive handling of timestamp related enums in Pinot query

shenyu0127 commented on issue #10749:
URL: https://github.com/apache/pinot/issues/10749#issuecomment-1544714802

   It turns out Pinot's `EXTRACT` function is case insensitive. So we don't need to make any changes for this function.
   
   - The `ExtractTransformFunction` is [case sensitive](https://github.com/apache/pinot/blob/60ee5eb0e8a2cf8276565ae8b20fb81292315843/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java#L52).
   -  The [SQL Parser](https://github.com/apache/pinot/blob/6eeb9fb5946c3e08eb3f48c72205092517539e60/pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java#L130) converts the `field` to upper case.
       - For example, if the query is `select EXTRACT(month FROM '2017-06-15') from airlineStats`, the `SqlNodeList` is parsed as ``SELECT EXTRACT(MONTH FROM '2017-06-15') FROM `airlineStats` ``.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org