You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@icorps.com> on 2012/07/24 21:48:18 UTC
Review Request: Fixed error with empty display name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6120/
-----------------------------------------------------------
Review request for rave.
Description
-------
Fixed error with empty display name on the top bar, when there is no displayName for the user.
Diffs
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1365205
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/util/ControllerUtilsTest.java 1365205
Diff: https://reviews.apache.org/r/6120/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave-556: Fixed error with empty display name.
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6120/#review9551
-----------------------------------------------------------
Ship it!
LGTM!
- Anthony Carlucci
On July 27, 2012, 11:35 a.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6120/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 11:35 a.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Fixed error with empty display name on the top bar, when there is no displayName for the user.
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1365541
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/util/ControllerUtilsTest.java 1365541
>
> Diff: https://reviews.apache.org/r/6120/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
Re: Review Request: Rave-556: Fixed error with empty display name.
Posted by Daniel Gornstein <dg...@icorps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6120/
-----------------------------------------------------------
(Updated July 27, 2012, 11:35 a.m.)
Review request for rave.
Summary (updated)
-----------------
Rave-556: Fixed error with empty display name.
Description
-------
Fixed error with empty display name on the top bar, when there is no displayName for the user.
Diffs
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1365541
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/util/ControllerUtilsTest.java 1365541
Diff: https://reviews.apache.org/r/6120/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Fixed error with empty display name.
Posted by Daniel Gornstein <dg...@icorps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6120/
-----------------------------------------------------------
(Updated July 25, 2012, 2:09 p.m.)
Review request for rave.
Changes
-------
Changed the function calculateDisplayName to getDisplayName upon request that calculate was not the right word.
Description
-------
Fixed error with empty display name on the top bar, when there is no displayName for the user.
Diffs (updated)
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java 1365541
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/util/ControllerUtilsTest.java 1365541
Diff: https://reviews.apache.org/r/6120/diff/
Testing
-------
Thanks,
Daniel Gornstein