[jira] [Commented] (SOLR-9215) QT parameter doesn't appear to function anymore

["Shawn Heisey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428195#comment-15428195 ] 

Shawn Heisey commented on SOLR-9215:
------------------------------------

bq. Confusing things a little is SolrJ... you can specify the request handler via the "qt" param (SolrQuery.setRequestHandler works this way). When SolrJ issues the HTTP request, it will look at "qt" to see if it starts with a "/" and send it there. I wish it would also then remove 'qt' since it effectively consumed it's purpose but it does not, which is misleading when on the Solr side you see logged a qt param that Solr ignores server-side.

+1.  Sorry for the late arrival here ... I'm catching up on email that has sat unread for a while and noticed the last few comments.

I've thought about this before, but it wasn't quite enough of an annoyance to prompt me into action.  I'm fine with SolrJ changing the URL endpoint when it sees a qt parameter starting with a forward slash, but when the endpoint is changed, the parameter should be removed.  Unfortunately, the params may not be a modifiable variety, which is probably why it wasn't done before.

Looking at the children of SolrParams ... I am not sure why we have so many implementations.  For the most part, they are very similar to each other.  Can we collapse all functionality of the children into the base class and deprecate the children in the same way that we did the "Server" variants of the Client classes?  If necessary, we could keep implementations that actually behave differently (like DocRowParams and MapSolrParams) around.

The idea above would make all params modifiable, which might be surprising to some users.  Javadoc updates would be important.  May need a separate issue.

> QT parameter doesn't appear to function anymore
> -----------------------------------------------
>
>                 Key: SOLR-9215
>                 URL: https://issues.apache.org/jira/browse/SOLR-9215
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 6.0, master (7.0)
>            Reporter: Markus Jelsma
>             Fix For: 6.2, master (7.0)
>
>
> The qt parameter doesn't seem to work anymore. A call directly to the /terms handler returns actual terms, as expected. Using the select handler but with qt=terms returns noting.
> http://localhost:8983/solr/logs/select?qt=terms&terms=true&terms.fl=compound_digest&terms.limit=100&terms.sort=index
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <response>
> <lst name="responseHeader">
>   <int name="status">0</int>
>   <int name="QTime">0</int>
>   <lst name="params">
>     <str name="qt">terms</str>
>     <str name="indent">true</str>
>     <str name="terms.fl">compound_digest</str>
>     <str name="terms.limit">100</str>
>     <str name="terms.sort">index</str>
>   </lst>
> </lst>
> <result name="response" numFound="0" start="0">
> </result>
> </response>
> {code}
> A peculiar detail, my unit tests that rely on the qt parameter are not affected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org