[GitHub] [nifi] mattyb149 commented on a change in pull request #5167: NIFI-8729 - Added DatabaseUserGroupProvider and DatabaseAccessPolicyProvider to administration-guide.adoc

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #5167:
URL: https://github.com/apache/nifi/pull/5167#discussion_r667110469



##########
File path: nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
##########
@@ -279,6 +279,22 @@ The default UserGroupProvider is the FileUserGroupProvider, however, you can dev
 
 NOTE: Initial User Identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated.
 
+===== DatabaseUserGroupProvider
+
+If you are using database for storing buckets and flows (like described in the 'Database Properties' section above), you can store the users, groups and policies in the same database either. 
+
+**Note:** This UserGroupProvider is available from version 0.8.0.
+
+
+The DatabaseUserGroupProvider takes the DB-connection information from `nifi-registry.properties` file, so in the `authorizers.xml` file you don't need to give any addition information about the DB (full example of `authorizers.xml` file for using database implementation desribed in `DatabaseAccessPolicyProvider` section).

Review comment:
       Minor nitpick, I suggest "database connection" instead of "DB-connection" and "additional" instead of "addition"

##########
File path: nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
##########
@@ -630,6 +646,40 @@ In this example, the users and groups are loaded from LDAP but the servers are m
 from an attribute in a LDAP entry based on the `User Identity Attribute`. The `NiFi Identity` values are established in the local file using the
 `Initial User Identity` properties.
 
+===== DatabaseAccessPolicyProvider
+Like `DatabaseUserGroupProvider` described above, this type of PolicyProvider takes the DB connection details from `nifi-registry.properties` file. 

Review comment:
       Same as above, recommend spelling out "database" rather than "DB", for consistency and clarity.

##########
File path: nifi-registry/nifi-registry-core/nifi-registry-docs/src/main/asciidoc/administration-guide.adoc
##########
@@ -279,6 +279,22 @@ The default UserGroupProvider is the FileUserGroupProvider, however, you can dev
 
 NOTE: Initial User Identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated.
 
+===== DatabaseUserGroupProvider
+
+If you are using database for storing buckets and flows (like described in the 'Database Properties' section above), you can store the users, groups and policies in the same database either. 

Review comment:
       Minor nitpick, I suggest "as" instead of "like" and "as well" instead of "either".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org