You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/25 10:21:11 UTC

[GitHub] [tvm] Mousius commented on a change in pull request #8023: [AOT] Initial implementation of --typed-operators

Mousius commented on a change in pull request #8023:
URL: https://github.com/apache/tvm/pull/8023#discussion_r638656525



##########
File path: src/driver/driver_api.cc
##########
@@ -200,8 +200,15 @@ std::pair<IRModule, IRModule> SplitDevHostFuncs(IRModule mod_mixed, const Target
   mixed_pass_list.push_back(tir::transform::ThreadSync("warp"));
   mixed_pass_list.push_back(tir::transform::InferFragment());
   mixed_pass_list.push_back(tir::transform::LowerThreadAllreduce());
-  mixed_pass_list.push_back(tir::transform::MakePackedAPI(0));
+
+  if (target->GetAttr<Bool>("typed-operators").value_or(Bool(true))) {

Review comment:
       I replied on the RFC agreeing to this sentiment, my proposal is something like `--packed-functions` which defaults to running MakePackedAPI? Maybe `--packed-internal-functions` or `--packed-operator-functions`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org