You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/25 06:07:38 UTC

[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1847: fix rocksdb&scylladb code checkstyle

javeme commented on code in PR #1847:
URL: https://github.com/apache/incubator-hugegraph/pull/1847#discussion_r857282776


##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java:
##########
@@ -281,13 +281,13 @@ protected BackendColumnIterator queryByCond(Session session,
                         prefix = (Id) r.value();
                         break;
                     case GTE:
-                        minEq = true;
                     case GT:
+                        minEq = true;
                         min = (Id) r.value();
                         break;
                     case LTE:
-                        maxEq = true;
                     case LT:
+                        maxEq = true;

Review Comment:
   changed the code logic



##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java:
##########
@@ -281,13 +281,13 @@ protected BackendColumnIterator queryByCond(Session session,
                         prefix = (Id) r.value();
                         break;
                     case GTE:
-                        minEq = true;
                     case GT:
+                        minEq = true;

Review Comment:
   changed the code logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org