You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/08 07:06:56 UTC
[GitHub] [incubator-zipkin] adriancole commented on a change in pull request
#2570: Ports all zipkin-server tests to Kotlin
adriancole commented on a change in pull request #2570: Ports all zipkin-server tests to Kotlin
URL: https://github.com/apache/incubator-zipkin/pull/2570#discussion_r281937945
##########
File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
##########
@@ -185,6 +185,10 @@ static void maybeLog(String prefix, ServiceRequestContext ctx, AggregatedHttpMes
}
if (content.isEmpty()) ZipkinHttpCollector.maybeLog("Empty POST body", ctx, request);
+ if (content.length() == 2 && "[]".equals(content.toStringAscii())) {
Review comment:
found a bug while doing this!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services