You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/04/03 23:46:03 UTC
[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1402:
Solr-12720
MarcusSorealheis opened a new pull request #1402: Solr-12720
URL: https://github.com/apache/lucene-solr/pull/1402
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* https://issues.apache.org/jira/browse/SOLR-12720: remove deprecated autoReplicaFailoverWaitAfterExpiration property.
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
remove deprecated autoReplicaFailoverWaitAfterExpiration property.
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull
request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403496510
##########
File path: solr/solr-ref-guide/src/solrcloud-autoscaling-triggers.adoc
##########
@@ -205,10 +205,29 @@ to add replicas on the live nodes to maintain the expected replication factor).
Refer to the section <<solrcloud-autoscaling-auto-add-replicas.adoc#solrcloud-autoscaling-auto-add-replicas, Autoscaling Automatically Adding Replicas>> to learn more about how the `.autoAddReplicas` trigger works.
-In addition to the parameters described at <<Trigger Configuration>>, this trigger supports one parameter, which is defined in the `<solrcloud>` section of `solr.xml`:
+If you would like to change the value of `.autoAddReplicas` trigger, you need to call the autoscaling API and use the `set-trigger` command to add a value for `waitFor`.
-`autoReplicaFailoverWaitAfterExpiration`::
-The minimum time in milliseconds to wait for initiating replacement of a replica after first noticing it not being live. This is important to prevent false positives while stopping or starting the cluster. The default is `120000` (2 minutes). The value provided for this parameter is used as the value for the `waitFor` parameter in the `.auto_add_replicas` trigger.
+.Example: Updating Trigger with wait for 5 seconds
+----
+{
+ "set-trigger": {
+ "name": "auto_add_replicas",
Review comment:
fat finger thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-608947141
@shalinmangar I killed the other PR and built on master as the base
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-608981419
@shalinmangar I'm not sure if this is what you meant originally on the last PR but I think so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1402: SOLR-12720 Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454640
##########
File path: solr/CHANGES.txt
##########
@@ -53,6 +53,10 @@ Other Changes
* SOLR-13893: Remove support to read BlobRepository's max jar size from deprecated `runtme.lib.size` system property
(Erick Erickson, Kesharee Nandan Vishwakarma, Munendra S N)
+* SOLR-12067: The default value of `CloudConfig.DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION` which replaces the
Review comment:
This statement is no longer true. Just mention `SOLR-12720: Remove support for autoReplicaFailoverWaitAfterExpiration` and add something to the upgrade notes saying that this is now removed and the way to change the auto add replica wait period is to change the `waitFor` attribute of `.auto_add_replicas` trigger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-609394019
@shalinmangar another precommit failure unrelated to my code:
```check-licenses:
[echo] License check under: /home/runner/work/lucene-solr/lucene-solr/solr
[licenses] CHECKSUM FAILED for /home/runner/work/lucene-solr/lucene-solr/solr/server/start.jar (expected: "ddb54190e858875fb681a6b9dd630a3609eaa513" was: "d5aa7d9c9cb261a9b4c460c918fd972d1a9882ed")
[licenses] Scanned 254 JAR file(s) for licenses (in 1.10s.), 1 error(s).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-608983484
not sure if there is a run tests hook or something of the like, or if gradle caught something legitimate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1402: SOLR-12720 Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454481
##########
File path: solr/core/src/java/org/apache/solr/core/CloudConfig.java
##########
@@ -50,6 +50,8 @@
private final String pkiHandlerPublicKeyPath;
+ public static final int DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION = 120000;
Review comment:
Let's move this to OverseerTriggerThread because that's the only class which uses this constant. Maybe rename to `DEFAULT_AUTO_ADD_REPLICA_WAIT_FOR_SECONDS` and set it to `120`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-609081501
all changes made @shalinmangar take a look at your leisure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1402: SOLR-12720 Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454201
##########
File path: solr/solr-ref-guide/src/solrcloud-autoscaling-triggers.adoc
##########
@@ -205,10 +205,29 @@ to add replicas on the live nodes to maintain the expected replication factor).
Refer to the section <<solrcloud-autoscaling-auto-add-replicas.adoc#solrcloud-autoscaling-auto-add-replicas, Autoscaling Automatically Adding Replicas>> to learn more about how the `.autoAddReplicas` trigger works.
-In addition to the parameters described at <<Trigger Configuration>>, this trigger supports one parameter, which is defined in the `<solrcloud>` section of `solr.xml`:
+If you would like to change the value of `.autoAddReplicas` trigger, you need to call the autoscaling API and use the `set-trigger` command to add a value for `waitFor`.
-`autoReplicaFailoverWaitAfterExpiration`::
-The minimum time in milliseconds to wait for initiating replacement of a replica after first noticing it not being live. This is important to prevent false positives while stopping or starting the cluster. The default is `120000` (2 minutes). The value provided for this parameter is used as the value for the `waitFor` parameter in the `.auto_add_replicas` trigger.
+.Example: Updating Trigger with wait for 5 seconds
+----
+{
+ "set-trigger": {
+ "name": "auto_add_replicas",
Review comment:
This name should be `.auto_add_replicas` (notice the leading `.` dot character)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#issuecomment-608983621
to me, both of these look like network failures:
```
> Could not resolve all artifacts for configuration ':classpath'.
> Could not download maven-model-3.6.2.jar (org.apache.maven:maven-model:3.6.2)
> Could not get resource 'https://plugins.gradle.org/m2/org/apache/maven/maven-model/3.6.2/maven-model-3.6.2.jar'.
> Connection reset
> Could not download plexus-utils-3.2.1.jar (org.codehaus.plexus:plexus-utils:3.2.1)
> Could not get resource 'https://plugins.gradle.org/m2/org/codehaus/plexus/plexus-utils/3.2.1/plexus-utils-3.2.1.jar'.
> Connection reset
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] asfgit closed pull request #1402: SOLR-12720
Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1402: SOLR-12720 Deprecated Auto Add Replica in XML
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454335
##########
File path: solr/core/src/java/org/apache/solr/core/CloudConfig.java
##########
@@ -143,7 +141,6 @@ public String getPkiHandlerPublicKeyPath() {
private static final int DEFAULT_LEADER_CONFLICT_RESOLVE_WAIT = 180000;
private static final int DEFAULT_CREATE_COLLECTION_ACTIVE_WAIT = 45; // 45 seconds
private static final boolean DEFAULT_CREATE_COLLECTION_CHECK_LEADER_ACTIVE = false;
-
private static final int DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION = 120000;
Review comment:
We can rid of this constant from CloudConfigBuilder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org