You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/08 17:45:57 UTC

Review Request 71027: Renamed Role::allocatedResources to Role::allocatedAndOfferedResources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71027/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Repository: mesos


Description
-------

This exposes allocated + offered, so it has been renamed accordingly.


Diffs
-----

  src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
  src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 
  src/master/readonly_handler.cpp 0d1e3dc19352863263c3e8992a63852c7f27225b 


Diff: https://reviews.apache.org/r/71027/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler

Re: Review Request 71027: Renamed Role::allocatedResources to Role::allocatedAndOfferedResources.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71027/#review216427
-----------------------------------------------------------


Ship it!





src/master/master.hpp
Lines 2702-2716 (original), 2702-2716 (patched)
<https://reviews.apache.org/r/71027/#comment303654>

    Looking at the resource json writer, we should be able to just use resource quantities. The only obstacle seems to be the unfortunately named `_revocable`:
    
    https://github.com/apache/mesos/blob/master/src/common/http.cpp#L720



src/master/master.hpp
Lines 2714-2715 (original), 2714-2715 (patched)
<https://reviews.apache.org/r/71027/#comment303655>

    we are adding ranges here? another reason to use quantities.


- Meng Zhu


On July 8, 2019, 10:45 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71027/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 10:45 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This exposes allocated + offered, so it has been renamed accordingly.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
>   src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 
>   src/master/readonly_handler.cpp 0d1e3dc19352863263c3e8992a63852c7f27225b 
> 
> 
> Diff: https://reviews.apache.org/r/71027/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>