You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 14:40:10 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12486: Improve UI file naming/patterns
ryanahamilton opened a new pull request #12486:
URL: https://github.com/apache/airflow/pull/12486
- Drops an unnecessary use of "master" from the codebase in the spirit of #9351.
- Establishes naming pattern (depicted below) where asset names correlate with the template name that consumes them.
**Files (sample) before:**
```
static/
├─ css/
│ ├─ graph.css
│ ├─ main.css
├─ js/
│ ├─ base.js
│ ├─ graph.js
templates/
├─ airflow/
│ ├─ graph.html
│ ├─ master.html
```
**Files (sample) after:**
```
static/
├─ css/
│ ├─ graph.css
│ ├─ main.css
├─ js/
│ ├─ graph.js
│ ├─ main.js
templates/
├─ airflow/
│ ├─ graph.html
│ ├─ main.html
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12486: Improve UI file naming/patterns
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12486:
URL: https://github.com/apache/airflow/pull/12486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12486: Improve UI file naming/patterns
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12486:
URL: https://github.com/apache/airflow/pull/12486#issuecomment-730444570
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org