[GitHub] [inlong] gong commented on a diff in pull request #7654: [INLONG-7653][Sort] Support archiving dirty data and metrics for Iceberg connector

["gong (via GitHub)" <gi...@apache.org>]

gong commented on code in PR #7654:
URL: https://github.com/apache/inlong/pull/7654#discussion_r1142832052


##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/FlinkDynamicTableFactory.java:
##########
@@ -248,6 +292,42 @@ public DynamicTableSink createDynamicTableSink(Context context) {
         }
     }
 
+    public String url(Map<String, String> properties) {

Review Comment:
   Maybe It is not used, remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org