[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests
URL: https://github.com/apache/incubator-druid/pull/8350#discussion_r317786474
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java
 ##########
 @@ -51,13 +48,13 @@ public HttpResponse getResponse()
     return response;
   }
 
-  public StringBuilder getBuilder()
-  {
-    return builder;
-  }
+  /**
+   * Append a new chunk of data.
+   */
+  public abstract FullResponseHolder addChunk(T chunk);
 
-  public String getContent()
-  {
-    return builder.toString();
-  }
+  /**
+   * Get the accumulated data via {@link #addChunk}.
+   */
+  public abstract T getAccumulated();
 
 Review comment:
   nit: Is `getAccumulated` a better name for this method than `getContent` was? I know the bytes response holder previously had a `getBytes` instead of `getContent`, but 'content' seems pretty universal to the idea of a response to me, where as i find `getAccumulated` to be a bit less intuitive in this context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org